Re: [PATCH v2] IB/core,rdmavt,hfi1,opa-vnic: Send OPA cap_mask3 in trap

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]

On Sun, Jun 04, 2017 at 11:13:21PM -0700, Vishwanathapura, Niranjana wrote:
> On Sun, Jun 04, 2017 at 07:46:00PM +0300, Leon Romanovsky wrote:
> > On Thu, Jun 01, 2017 at 05:04:02PM -0700, Vishwanathapura, Niranjana wrote:
> > > --- a/drivers/infiniband/hw/hfi1/mad.c
> > > +++ b/drivers/infiniband/hw/hfi1/mad.c
> > > @@ -260,6 +260,7 @@ void hfi1_cap_mask_chg(struct rvt_dev_info *rdi, u8 port_num)
> > >  	data.issuer_lid = cpu_to_be32(lid);
> > >  	data.ntc_144.lid = data.issuer_lid;
> > >  	data.ntc_144.new_cap_mask = cpu_to_be32(ibp->rvp.port_cap_flags);
> > > +	data.ntc_144.cap_mask3 = cpu_to_be16(ibp->rvp.port_cap3_flags);
> > >
> > >  	send_trap(ibp, &data, sizeof(data));
> > >  }
> > > @@ -704,11 +705,7 @@ static int __subn_get_opa_portinfo(struct opa_smp *smp, u32 am, u8 *data,
> > >  	buffer_units |= (dd->vl15_init << 11) & OPA_PI_MASK_BUF_UNIT_VL15_INIT;
> > >  	pi->buffer_units = cpu_to_be32(buffer_units);
> > >
> > > -	pi->opa_cap_mask = cpu_to_be16(OPA_CAP_MASK3_IsSharedSpaceSupported |
> > > -				       OPA_CAP_MASK3_IsEthOnFabricSupported);
> > > -	/* Driver does not support mcast/collective configuration */
> > > -	pi->opa_cap_mask &=
> > > -		cpu_to_be16(~OPA_CAP_MASK3_IsAddrRangeConfigSupported);
> > > +	pi->opa_cap_mask = cpu_to_be16(ibp->rvp.port_cap3_flags);
> > >  	pi->collectivemask_multicastmask = ((HFI1_COLLECTIVE_NR & 0x7)
> > >  					    << 3 | (HFI1_MCAST_NR & 0x7));
> > >
> > > diff --git a/drivers/infiniband/hw/hfi1/mad.h b/drivers/infiniband/hw/hfi1/mad.h
> > > index 5aa3fd1..a4e2506 100644
> > > --- a/drivers/infiniband/hw/hfi1/mad.h
> > > +++ b/drivers/infiniband/hw/hfi1/mad.h
> > > @@ -115,7 +115,7 @@ struct opa_mad_notice_attr {
> > >  			__be32	lid;		/* LID where change occurred */
> > >  			__be32	new_cap_mask;	/* new capability mask */
> > >  			__be16	reserved2;
> > > -			__be16	cap_mask;
> > > +			__be16	cap_mask3;
> >
> > Did I miss the usage of that cap_mask3 field?
> >
>
> It is being set in mad.c above in this patch before sending the trap.

Yes, thanks, I missed it.

At least, we will have one user who writes enum from this ib_port_modify_flags.

Thanks

>
> Niranjana
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]