public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: ahmad omary <ahmad151084-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Ahmad Omary <ahmad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Tzahi Oved <tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Alex Rosenbaum <Alexr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Ariel Levkovich <lariel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Liran Liss <liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [RFC] libibverbs IB Device Memory support
Date: Mon, 5 Jun 2017 11:20:58 -0600	[thread overview]
Message-ID: <20170605172058.GB20477@obsidianresearch.com> (raw)
In-Reply-To: <CADWppnpd9Up7wUTxRgSinhgx3kt3+0bKwgt6P_d3CV1oA90isQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Wed, May 10, 2017 at 02:25:23PM +0300, ahmad omary wrote:

> struct ibv_dm *ibv_alloc_dm(struct ibv_context *context,
>    struct ibv_alloc_dm_attr *dm_attr);
> 
> struct ibv_alloc_dm_attr{
> size_t length;
> uint32_t comp_mask; /*enable future extensions*/
> }

Can we please stop this madness where every function call needs to
accept a struct?

It is perfectly fine to add new function calls if new arguments are
needed someday.

> int ibv_memcpy_dm(struct ibv_dm *dm, struct ibv_memcpy_dm_attr *
> memcpy_dm_attr);

To be clear, this is has to be a sycall, right?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-06-05 17:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 11:25 [RFC] libibverbs IB Device Memory support ahmad omary
     [not found] ` <CADWppnpd9Up7wUTxRgSinhgx3kt3+0bKwgt6P_d3CV1oA90isQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-05 16:44   ` Christoph Lameter
     [not found]     ` <alpine.DEB.2.20.1706051141230.26831-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2017-06-05 17:08       ` Leon Romanovsky
     [not found]         ` <20170605170825.GP6868-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-05 17:17           ` Jason Gunthorpe
     [not found]             ` <20170605171749.GA20477-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-05 17:41               ` Leon Romanovsky
     [not found]                 ` <20170605174151.GR6868-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-05 22:11                   ` Christoph Lameter
     [not found]                     ` <alpine.DEB.2.20.1706051705350.886-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2017-06-06 11:51                       ` Ahmad Omary
     [not found]                         ` <AM4PR0501MB1956B596450F3BC38806E775C4CB0-dp/nxUn679ggcKT3UpMsY8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-06-06 15:25                           ` Liran Liss
2017-06-06 15:30                           ` Christoph Lameter
     [not found]                             ` <alpine.DEB.2.20.1706061022270.16819-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2017-06-08 13:10                               ` Liran Liss
2017-06-06  7:10       ` Christoph Hellwig
2017-06-05 17:20   ` Jason Gunthorpe [this message]
     [not found]     ` <20170605172058.GB20477-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-06  5:52       ` Leon Romanovsky
     [not found]         ` <20170606055229.GT6868-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-06  6:31           ` Leon Romanovsky
2017-06-06 16:34           ` Jason Gunthorpe
2017-06-06  7:35   ` Sagi Grimberg
     [not found]     ` <46b1a06d-5936-799c-7743-097c579971ef-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-06 16:49       ` Logan Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170605172058.GB20477@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=Alexr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=ahmad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=ahmad151084-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=lariel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=tzahio-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox