From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: "leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"sagi-TmH2Wj2nsNJBDLzU/O5InQ@public.gmane.org"
<sagi-TmH2Wj2nsNJBDLzU/O5InQ@public.gmane.org>,
"ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
<yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"sriharsha.basavapatna-dY08KVG/lbpWk0Htik3J/w@public.gmane.org"
<sriharsha.basavapatna-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org"
<somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org"
<devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org"
<selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] IB/core: Add generic function to extract IB speed from netdev
Date: Tue, 6 Jun 2017 22:05:43 +0300 [thread overview]
Message-ID: <20170606190542.GC4341@yuvallap> (raw)
In-Reply-To: <1496763416.2692.3.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
On Tue, Jun 06, 2017 at 03:36:59PM +0000, Bart Van Assche wrote:
> On Tue, 2017-06-06 at 15:38 +0300, Yuval Shaia wrote:
> > Logic of retriving netdev speed from net_device and translating it to IB
> > speed is implemented both in rxe and bnxt drivers.
>
> Hello Yuval,
>
> Have you noticed that there is another copy of eth_speed_to_ib_speed() in
> the usnic driver?
Missed that one.
I will post v1 of the patch soon that utilize this new function in
usnic_ib_query_port.
Problem i see here is that usnic_ib_query_port directly call
__ethtool_get_link_ksettings and not via netdev->ethtool_ops. So asking
usnic folks to review and approve the change.
>
> Bart.--
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-06-06 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 12:38 [PATCH] IB/core: Add generic function to extract IB speed from netdev Yuval Shaia
[not found] ` <20170606123854.1236-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-06-06 15:36 ` Bart Van Assche
[not found] ` <1496763416.2692.3.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-06-06 19:05 ` Yuval Shaia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606190542.GC4341@yuvallap \
--to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagi-TmH2Wj2nsNJBDLzU/O5InQ@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=sriharsha.basavapatna-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox