public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Artemy Kovalyov <artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	yosefe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	anag-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [RFC 2/5] verbs: Introduce tag matching SRQ
Date: Mon, 12 Jun 2017 14:50:15 -0600	[thread overview]
Message-ID: <20170612205015.GA24893@obsidianresearch.com> (raw)
In-Reply-To: <0c00c167-1cfb-d169-134d-d608079b53df-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

On Mon, Jun 12, 2017 at 11:38:09PM +0300, Artemy Kovalyov wrote:
> 
> 
> On 12/06/2017 19:38, Jason Gunthorpe wrote:
> >On Mon, Jun 12, 2017 at 09:42:44AM +0300, Artemy Kovalyov wrote:
> >> enum ibv_srq_type {
> >> 	IBV_SRQT_BASIC,
> >>-	IBV_SRQT_XRC
> >>+	IBV_SRQT_XRC,
> >>+	IBV_SRQT_TAG_MATCHING
> >> };
> >
> >Please put trailing commas on all these enum changes in all patches
> 
> So do we drop overboard all -Wpedantic users?

Eh? Try it.

You only get warnings if your compiler is running in c89 or ansi mode,
which went 'overboard' a long time ago.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-06-12 20:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12  6:42 [RFC 0/5] Hardware tag matching Artemy Kovalyov
     [not found] ` <1497249767-15353-1-git-send-email-artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-06-12  6:42   ` [RFC 1/5] verbs: Expose tag matching capabilities Artemy Kovalyov
2017-06-12  6:42   ` [RFC 2/5] verbs: Introduce tag matching SRQ Artemy Kovalyov
     [not found]     ` <1497249767-15353-3-git-send-email-artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-06-12 16:38       ` Jason Gunthorpe
     [not found]         ` <20170612163856.GA12282-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-12 20:38           ` Artemy Kovalyov
     [not found]             ` <0c00c167-1cfb-d169-134d-d608079b53df-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-06-12 20:50               ` Jason Gunthorpe [this message]
     [not found]                 ` <20170612205015.GA24893-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-12 21:09                   ` Artemy Kovalyov
     [not found]                     ` <af1d8a49-7d4a-6f3c-b5a1-c4aba79d74d1-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-06-12 21:18                       ` Jason Gunthorpe
     [not found]                         ` <20170612211816.GA27649-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-12 21:31                           ` Artemy Kovalyov
     [not found]                             ` <bd402c01-f12e-52e8-c96f-0d2db0459b22-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-06-12 21:40                               ` Jason Gunthorpe
     [not found]                                 ` <20170612214047.GA30578-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-12 21:45                                   ` Artemy Kovalyov
2017-06-12  6:42   ` [RFC 3/5] verbs: Tag matching list manipulation interface Artemy Kovalyov
2017-06-12  6:42   ` [RFC 4/5] verbs: Tag matching send interface Artemy Kovalyov
     [not found]     ` <1497249767-15353-5-git-send-email-artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-06-12 16:41       ` Jason Gunthorpe
     [not found]         ` <20170612164140.GB12282-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-13  6:33           ` Leon Romanovsky
2017-06-12  6:42   ` [RFC 5/5] verbs: Tag matching receive interface Artemy Kovalyov
     [not found]     ` <1497249767-15353-6-git-send-email-artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-06-12 16:42       ` Jason Gunthorpe
     [not found]         ` <20170612164206.GC12282-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-13  6:34           ` Leon Romanovsky
2017-06-12  7:40   ` [RFC 0/5] Hardware tag matching Christoph Hellwig
     [not found]     ` <20170612074055.GA24879-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-06-12  9:41       ` Artemy Kovalyov
     [not found]         ` <628acd1f-7502-be87-df2e-48475f34fdd8-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-06-12 10:46           ` Leon Romanovsky
     [not found]             ` <20170612104600.GA2576-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-12 11:05               ` Christoph Hellwig
     [not found]                 ` <20170612110507.GA14990-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-06-12 11:13                   ` Leon Romanovsky
2017-06-12 16:40   ` Jason Gunthorpe
     [not found]     ` <20170612164001.GB11993-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-06-12 20:43       ` Artemy Kovalyov
2017-06-19 10:39   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612205015.GA24893@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=anag-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=yosefe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox