From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC 2/5] verbs: Introduce tag matching SRQ Date: Mon, 12 Jun 2017 15:18:16 -0600 Message-ID: <20170612211816.GA27649@obsidianresearch.com> References: <1497249767-15353-1-git-send-email-artemyko@mellanox.com> <1497249767-15353-3-git-send-email-artemyko@mellanox.com> <20170612163856.GA12282@obsidianresearch.com> <0c00c167-1cfb-d169-134d-d608079b53df@mellanox.com> <20170612205015.GA24893@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Artemy Kovalyov Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, yosefe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, anag-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Jun 13, 2017 at 12:09:29AM +0300, Artemy Kovalyov wrote: > > > On 12/06/2017 23:50, Jason Gunthorpe wrote: > >On Mon, Jun 12, 2017 at 11:38:09PM +0300, Artemy Kovalyov wrote: > >> > >> > >>On 12/06/2017 19:38, Jason Gunthorpe wrote: > >>>On Mon, Jun 12, 2017 at 09:42:44AM +0300, Artemy Kovalyov wrote: > >>>>enum ibv_srq_type { > >>>> IBV_SRQT_BASIC, > >>>>- IBV_SRQT_XRC > >>>>+ IBV_SRQT_XRC, > >>>>+ IBV_SRQT_TAG_MATCHING > >>>>}; > >>> > >>>Please put trailing commas on all these enum changes in all patches > >> > >>So do we drop overboard all -Wpedantic users? > > > >Eh? Try it. > > > >You only get warnings if your compiler is running in c89 or ansi mode, > >which went 'overboard' a long time ago. > Bare -Wpedantic -Werror fails with this. You need -std=c99 on older compilers. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html