* [PATCH] IB/mlx5: Fix a warning message @ 2017-06-14 9:15 Dan Carpenter 2017-06-14 9:19 ` Matan Barak 0 siblings, 1 reply; 7+ messages in thread From: Dan Carpenter @ 2017-06-14 9:15 UTC (permalink / raw) To: Matan Barak, Arnd Bergmann Cc: Leon Romanovsky, Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma, kernel-janitors "umem" is a valid pointer. We intended to print "*umem" instead. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index 763bb5b36144..86af54b0e414 100644 --- a/drivers/infiniband/hw/mlx5/mr.c +++ b/drivers/infiniband/hw/mlx5/mr.c @@ -825,7 +825,7 @@ static int mr_umem_get(struct ib_pd *pd, u64 start, u64 length, access_flags, 0); err = PTR_ERR_OR_ZERO(*umem); if (err < 0) { - mlx5_ib_err(dev, "umem get failed (%ld)\n", PTR_ERR(umem)); + mlx5_ib_err(dev, "umem get failed (%ld)\n", PTR_ERR(*umem)); return err; } ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] IB/mlx5: Fix a warning message 2017-06-14 9:15 [PATCH] IB/mlx5: Fix a warning message Dan Carpenter @ 2017-06-14 9:19 ` Matan Barak 2017-06-14 9:52 ` Dan Carpenter 0 siblings, 1 reply; 7+ messages in thread From: Matan Barak @ 2017-06-14 9:19 UTC (permalink / raw) To: Dan Carpenter Cc: Matan Barak, Arnd Bergmann, Leon Romanovsky, Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma, kernel-janitors On Wed, Jun 14, 2017 at 12:15 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > "umem" is a valid pointer. We intended to print "*umem" instead. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > index 763bb5b36144..86af54b0e414 100644 > --- a/drivers/infiniband/hw/mlx5/mr.c > +++ b/drivers/infiniband/hw/mlx5/mr.c > @@ -825,7 +825,7 @@ static int mr_umem_get(struct ib_pd *pd, u64 start, u64 length, > access_flags, 0); > err = PTR_ERR_OR_ZERO(*umem); > if (err < 0) { > - mlx5_ib_err(dev, "umem get failed (%ld)\n", PTR_ERR(umem)); > + mlx5_ib_err(dev, "umem get failed (%ld)\n", PTR_ERR(*umem)); I think it's better just to print err :) > return err; > } > Thanks, Matan > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] IB/mlx5: Fix a warning message 2017-06-14 9:19 ` Matan Barak @ 2017-06-14 9:52 ` Dan Carpenter 2017-06-14 9:57 ` Matan Barak 0 siblings, 1 reply; 7+ messages in thread From: Dan Carpenter @ 2017-06-14 9:52 UTC (permalink / raw) To: Matan Barak Cc: Matan Barak, Arnd Bergmann, Leon Romanovsky, Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma, kernel-janitors-u79uwXL29TY76Z2rM5mHXA On Wed, Jun 14, 2017 at 12:19:57PM +0300, Matan Barak wrote: > On Wed, Jun 14, 2017 at 12:15 PM, Dan Carpenter > <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote: > > "umem" is a valid pointer. We intended to print "*umem" instead. > > > > Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > > > > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c > > index 763bb5b36144..86af54b0e414 100644 > > --- a/drivers/infiniband/hw/mlx5/mr.c > > +++ b/drivers/infiniband/hw/mlx5/mr.c > > @@ -825,7 +825,7 @@ static int mr_umem_get(struct ib_pd *pd, u64 start, u64 length, > > access_flags, 0); > > err = PTR_ERR_OR_ZERO(*umem); > > if (err < 0) { > > - mlx5_ib_err(dev, "umem get failed (%ld)\n", PTR_ERR(umem)); > > + mlx5_ib_err(dev, "umem get failed (%ld)\n", PTR_ERR(*umem)); > > I think it's better just to print err :) > I don't understand what you're saying. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] IB/mlx5: Fix a warning message 2017-06-14 9:52 ` Dan Carpenter @ 2017-06-14 9:57 ` Matan Barak [not found] ` <CAAKD3BDGH1STMhcCgz=K6-8EtnGGOYkx7KPS+iPidUiuLmpjNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Matan Barak @ 2017-06-14 9:57 UTC (permalink / raw) To: Dan Carpenter Cc: Matan Barak, Arnd Bergmann, Leon Romanovsky, Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma, kernel-janitors On Wed, Jun 14, 2017 at 12:52 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Wed, Jun 14, 2017 at 12:19:57PM +0300, Matan Barak wrote: >> On Wed, Jun 14, 2017 at 12:15 PM, Dan Carpenter >> <dan.carpenter@oracle.com> wrote: >> > "umem" is a valid pointer. We intended to print "*umem" instead. >> > >> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> > >> > diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c >> > index 763bb5b36144..86af54b0e414 100644 >> > --- a/drivers/infiniband/hw/mlx5/mr.c >> > +++ b/drivers/infiniband/hw/mlx5/mr.c >> > @@ -825,7 +825,7 @@ static int mr_umem_get(struct ib_pd *pd, u64 start, u64 length, >> > access_flags, 0); >> > err = PTR_ERR_OR_ZERO(*umem); >> > if (err < 0) { >> > - mlx5_ib_err(dev, "umem get failed (%ld)\n", PTR_ERR(umem)); >> > + mlx5_ib_err(dev, "umem get failed (%ld)\n", PTR_ERR(*umem)); >> >> I think it's better just to print err :) >> > > I don't understand what you're saying. > mlx5_ib_err(dev, "umem get failed (%d)\n", err); > regards, > dan carpenter > Thanks, Matan ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CAAKD3BDGH1STMhcCgz=K6-8EtnGGOYkx7KPS+iPidUiuLmpjNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* [PATCH v2] IB/mlx5: Fix a warning message [not found] ` <CAAKD3BDGH1STMhcCgz=K6-8EtnGGOYkx7KPS+iPidUiuLmpjNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2017-06-14 10:20 ` Dan Carpenter 2017-06-14 10:41 ` Leon Romanovsky [not found] ` <20170614102009.GA5171-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org> 0 siblings, 2 replies; 7+ messages in thread From: Dan Carpenter @ 2017-06-14 10:20 UTC (permalink / raw) To: Matan Barak Cc: Leon Romanovsky, Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA, kernel-janitors-u79uwXL29TY76Z2rM5mHXA "umem" is a valid pointer. We intended to print "*umem" or even just "err" instead. Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> --- v2: style change diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index 763bb5b36144..2c89757b0223 100644 --- a/drivers/infiniband/hw/mlx5/mr.c +++ b/drivers/infiniband/hw/mlx5/mr.c @@ -825,7 +825,7 @@ static int mr_umem_get(struct ib_pd *pd, u64 start, u64 length, access_flags, 0); err = PTR_ERR_OR_ZERO(*umem); if (err < 0) { - mlx5_ib_err(dev, "umem get failed (%ld)\n", PTR_ERR(umem)); + mlx5_ib_err(dev, "umem get failed (%d)\n", err); return err; } -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] IB/mlx5: Fix a warning message 2017-06-14 10:20 ` [PATCH v2] " Dan Carpenter @ 2017-06-14 10:41 ` Leon Romanovsky [not found] ` <20170614102009.GA5171-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org> 1 sibling, 0 replies; 7+ messages in thread From: Leon Romanovsky @ 2017-06-14 10:41 UTC (permalink / raw) To: Dan Carpenter Cc: Matan Barak, Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma, kernel-janitors [-- Attachment #1: Type: text/plain, Size: 296 bytes --] On Wed, Jun 14, 2017 at 01:20:09PM +0300, Dan Carpenter wrote: > "umem" is a valid pointer. We intended to print "*umem" or even just > "err" instead. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > v2: style change > Thanks, Acked-by: Leon Romanovsky <leonro@mellanox.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20170614102009.GA5171-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>]
* Re: [PATCH v2] IB/mlx5: Fix a warning message [not found] ` <20170614102009.GA5171-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org> @ 2017-07-22 17:30 ` Doug Ledford 0 siblings, 0 replies; 7+ messages in thread From: Doug Ledford @ 2017-07-22 17:30 UTC (permalink / raw) To: Dan Carpenter, Matan Barak Cc: Leon Romanovsky, Sean Hefty, Hal Rosenstock, linux-rdma-u79uwXL29TY76Z2rM5mHXA, kernel-janitors-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1.1: Type: text/plain, Size: 452 bytes --] On 6/14/2017 6:20 AM, Dan Carpenter wrote: > "umem" is a valid pointer. We intended to print "*umem" or even just > "err" instead. > > Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> This was accepted into 4.13-rc, thanks. -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG Key ID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 884 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-22 17:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-14 9:15 [PATCH] IB/mlx5: Fix a warning message Dan Carpenter
2017-06-14 9:19 ` Matan Barak
2017-06-14 9:52 ` Dan Carpenter
2017-06-14 9:57 ` Matan Barak
[not found] ` <CAAKD3BDGH1STMhcCgz=K6-8EtnGGOYkx7KPS+iPidUiuLmpjNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-14 10:20 ` [PATCH v2] " Dan Carpenter
2017-06-14 10:41 ` Leon Romanovsky
[not found] ` <20170614102009.GA5171-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2017-07-22 17:30 ` Doug Ledford
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox