Re: [PATCH v2 19/19] sunrpc: Disable splice for krb5i

Jeff Layton
2017-06-22T17:13:03Z

On Mon, 2017-06-19 at 08:30 -0700, Christoph Hellwig wrote:
> On Mon, Jun 19, 2017 at 11:22:41AM -0400, Chuck Lever wrote:
> > I'm going to submit this again with a comment change and
> > Jeff's Reviewed-by. Can I add your Reviewed-by as well?
>
> It looks ok as a quick fix for me but at least needs a big comment.
> I'd also be much happier if we could find and fix the root cause.

Don't we already know the root cause?

There's nothing that holds the data stable, so we calculate the checksum
but by the time we get to transmitting the frame it's no longer valid.
Is there something else that should be preventing this?

In any case, I do agree that some comments explaining this would be a
good thing.
--
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>