public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: "Mintz, Yuval" <Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Kalderon,
	Michal" <Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP
Date: Mon, 19 Jun 2017 04:36:31 +0200	[thread overview]
Message-ID: <20170619023631.GB13292@lunn.ch> (raw)
In-Reply-To: <BLUPR0701MB20047CD16002072436A61EA38DC70-v5ruerSQ/oj1oiTf6dR/AE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>

> I can't really say I understand who would benefit from adding 
> "while at it remove redundant inclusion of header file"
> to the commit log message [And even less from splitting this into its own patch].

Part of it is trust.

If you say you are just renaming, not making any change, reviewers
will not look too deep at the change. But if you do make a change, but
not say anything about it, we loose trust in what you are saying.

    Andrew

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-06-19  2:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-18 11:50 [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP Yuval Mintz
     [not found] ` <20170618115035.2156-1-Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-06-18 11:50   ` [PATCH v2 net-next 1/7] qed: Chain support for external PBL Yuval Mintz
2017-06-18 11:50   ` [PATCH v2 net-next 3/7] qed: Disable RoCE dpm when DCBx change occurs Yuval Mintz
2017-06-18 11:50   ` [PATCH v2 net-next 4/7] qed*: Rename qede_roce.[ch] Yuval Mintz
     [not found]     ` <20170618115035.2156-5-Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-06-18 12:00       ` Kalderon, Michal
2017-06-18 11:50   ` [PATCH v2 net-next 6/7] qed: Wait for resources before FUNC_CLOSE Yuval Mintz
2017-06-18 16:29   ` [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP David Miller
2017-06-18 17:54     ` Mintz, Yuval
2017-06-19  1:40       ` David Miller
     [not found]       ` <BLUPR0701MB20047CD16002072436A61EA38DC70-v5ruerSQ/oj1oiTf6dR/AE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-06-19  2:36         ` Andrew Lunn [this message]
2017-06-18 11:50 ` [PATCH v2 net-next 2/7] qed: RoCE EDPM to honor PFC Yuval Mintz
2017-06-18 11:50 ` [PATCH v2 net-next 5/7] qed*: Set rdma generic functions prefix Yuval Mintz
2017-06-18 11:50 ` [PATCH v2 net-next 7/7] qed: SPQ async callback registration Yuval Mintz
2017-06-18 13:14 ` [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP Christoph Hellwig
2017-06-19  6:28   ` Kalderon, Michal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619023631.GB13292@lunn.ch \
    --to=andrew-g2dyl2zd6by@public.gmane.org \
    --cc=Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox