public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Saeed Mahameed
	<saeedm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v6 for-4.13 0/7] Automatic affinity settings for nvme over rdma
Date: Mon, 19 Jun 2017 14:28:06 +0200	[thread overview]
Message-ID: <20170619122806.GA29061@lst.de> (raw)
In-Reply-To: <1497796677-15794-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>

Thanks Sagi,

the whole series looks great to me.

It would be even nicer if the maintainers of the various HCA drivers
could look into adding support..

On Sun, Jun 18, 2017 at 05:37:50PM +0300, Sagi Grimberg wrote:
> Doug, please consider this patch set for 4.13.
> Saeed, care to get this into your testing environment?
> 
> This patch set is aiming to automatically find the optimal
> queue <-> irq multi-queue assignments in storage ULPs (demonstrated
> on nvme-rdma) based on the underlying rdma device irq affinity
> settings.
> 
> Changes from v5:
> - updated change log for patch #2
> - removed nit indentation changes
> 
> Changes from v4:
> - removed mlx5e assumptions on device home node irq affinity mappings
> - rebased to 4.12-rc5
> 
> Changes from v3:
> - Renamed mlx5_disable_msix -> mlx5_free_pci_vectors for symmetry reasons
> 
> Changes from v2:
> - rebased to 4.12
> - added review tags
> 
> Changes from v1:
> - Removed mlx5e_get_cpu as Christoph suggested
> - Fixed up nvme-rdma queue comp_vector selection to get a better match
> - Added a comment on why we limit on @dev->num_comp_vectors
> - rebased to Jens's for-4.12/block
> - Collected review tags
> 
> Sagi Grimberg (7):
>   mlx5: convert to generic pci_alloc_irq_vectors
>   mlx5e: don't assume anything on the irq affinity mappings of the
>     device
>   mlx5: move affinity hints assignments to generic code
>   RDMA/core: expose affinity mappings per completion vector
>   mlx5: support ->get_vector_affinity
>   block: Add rdma affinity based queue mapping helper
>   nvme-rdma: use intelligent affinity based queue mappings
> 
>  block/Kconfig                                      |   5 +
>  block/Makefile                                     |   1 +
>  block/blk-mq-rdma.c                                |  54 +++++++++++
>  drivers/infiniband/hw/mlx5/main.c                  |   9 ++
>  drivers/net/ethernet/mellanox/mlx5/core/en.h       |   1 -
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c  |  54 +++++------
>  drivers/net/ethernet/mellanox/mlx5/core/eq.c       |   9 +-
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.c  |   2 +-
>  drivers/net/ethernet/mellanox/mlx5/core/health.c   |   2 +-
>  drivers/net/ethernet/mellanox/mlx5/core/main.c     | 106 ++++-----------------
>  .../net/ethernet/mellanox/mlx5/core/mlx5_core.h    |   1 -
>  drivers/nvme/host/rdma.c                           |  29 ++++--
>  include/linux/blk-mq-rdma.h                        |  10 ++
>  include/linux/mlx5/driver.h                        |   8 +-
>  include/rdma/ib_verbs.h                            |  25 ++++-
>  15 files changed, 174 insertions(+), 142 deletions(-)
>  create mode 100644 block/blk-mq-rdma.c
>  create mode 100644 include/linux/blk-mq-rdma.h
> 
> -- 
> 2.7.4
---end quoted text---
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-06-19 12:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-18 14:37 [PATCH v6 for-4.13 0/7] Automatic affinity settings for nvme over rdma Sagi Grimberg
     [not found] ` <1497796677-15794-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-06-18 14:37   ` [PATCH v6 for-4.13 1/7] mlx5: convert to generic pci_alloc_irq_vectors Sagi Grimberg
2017-06-18 14:37   ` [PATCH v6 for-4.13 2/7] mlx5e: don't assume anything on the irq affinity mappings of the device Sagi Grimberg
2017-06-18 14:37   ` [PATCH v6 for-4.13 3/7] mlx5: move affinity hints assignments to generic code Sagi Grimberg
2017-06-18 14:37   ` [PATCH v6 for-4.13 4/7] RDMA/core: expose affinity mappings per completion vector Sagi Grimberg
2017-06-18 14:37   ` [PATCH v6 for-4.13 5/7] mlx5: support ->get_vector_affinity Sagi Grimberg
2017-06-18 14:37   ` [PATCH v6 for-4.13 6/7] block: Add rdma affinity based queue mapping helper Sagi Grimberg
2017-06-18 14:37   ` [PATCH v6 for-4.13 7/7] nvme-rdma: use intelligent affinity based queue mappings Sagi Grimberg
2017-06-19 12:28   ` Christoph Hellwig [this message]
     [not found]     ` <20170619122806.GA29061-jcswGhMUV9g@public.gmane.org>
2017-06-26 10:01       ` [PATCH v6 for-4.13 0/7] Automatic affinity settings for nvme over rdma Christoph Hellwig
     [not found]         ` <20170626100113.GA14446-jcswGhMUV9g@public.gmane.org>
2017-06-27  7:09           ` Sagi Grimberg
     [not found]             ` <7a91bc31-9a4d-a07c-002d-af06143c4257-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-08-03 15:22               ` Sagi Grimberg
     [not found]                 ` <2eecc5bb-e356-73e5-a2fc-1f1867a779f3-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-08-04 19:18                   ` Doug Ledford
     [not found]                     ` <1501874327.79618.12.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-07  0:23                       ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170619122806.GA29061@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=saeedm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox