From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
rajesh.borundia-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB: Move PCI dependency from root KConfig to HW's KConfigs
Date: Mon, 26 Jun 2017 13:38:52 +0300 [thread overview]
Message-ID: <20170626103850.GA6506@yuvallap> (raw)
In-Reply-To: <20170626100231.GC1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Mon, Jun 26, 2017 at 01:02:31PM +0300, Leon Romanovsky wrote:
> On Mon, Jun 26, 2017 at 11:53:13AM +0300, Yuval Shaia wrote:
> > No reason to have dependency on PCI for the entire infiniband stack so
> > move it to KConfig of only the drivers that actually using PCI.
> >
> > Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> > ---
> > drivers/infiniband/Kconfig | 1 -
> > drivers/infiniband/hw/cxgb3/Kconfig | 1 +
> > drivers/infiniband/hw/cxgb4/Kconfig | 1 +
> > drivers/infiniband/hw/hfi1/Kconfig | 1 +
> > drivers/infiniband/hw/i40iw/Kconfig | 1 +
> > drivers/infiniband/hw/qedr/Kconfig | 1 +
> > drivers/infiniband/hw/qib/Kconfig | 1 +
> > drivers/infiniband/sw/rdmavt/Kconfig | 1 +
>
> Why do you need PCI for rdmavt?
Saw calls such as get_pci_dev so just suspect, but you are right, i don't
see why SW device needs PCI.
>
> > drivers/infiniband/ulp/ipoib/Kconfig | 1 +
> > 9 files changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> > index 234fe01..568088a 100644
> > --- a/drivers/infiniband/Kconfig
> > +++ b/drivers/infiniband/Kconfig
> > @@ -1,6 +1,5 @@
> > menuconfig INFINIBAND
> > tristate "InfiniBand support"
> > - depends on PCI || BROKEN
>
> By the way, do you know why are we dependent on BROKEN?
No, assume that it is like if PCI is not defined the "break" configuration
or something like that.
Will be happy if you can shad some light on that.
>
> Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-26 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 8:53 [PATCH] IB: Move PCI dependency from root KConfig to HW's KConfigs Yuval Shaia
[not found] ` <20170626085313.6052-1-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-06-26 10:02 ` Leon Romanovsky
[not found] ` <20170626100231.GC1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-06-26 10:38 ` Yuval Shaia [this message]
2017-06-26 11:57 ` Leon Romanovsky
2017-06-26 14:33 ` kbuild test robot
2017-06-27 18:48 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626103850.GA6506@yuvallap \
--to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=rajesh.borundia-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox