Re: [PATCH] IB: Move PCI dependency from root KConfig to HW's KConfigs

Leon Romanovsky
2017-06-26T10:02:31Z

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On Mon, Jun 26, 2017 at 11:53:13AM +0300, Yuval Shaia wrote:
> No reason to have dependency on PCI for the entire infiniband stack so
> move it to KConfig of only the drivers that actually using PCI.
>
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/infiniband/Kconfig | 1 -
> drivers/infiniband/hw/cxgb3/Kconfig | 1 +
> drivers/infiniband/hw/cxgb4/Kconfig | 1 +
> drivers/infiniband/hw/hfi1/Kconfig | 1 +
> drivers/infiniband/hw/i40iw/Kconfig | 1 +
> drivers/infiniband/hw/qedr/Kconfig | 1 +
> drivers/infiniband/hw/qib/Kconfig | 1 +
> drivers/infiniband/sw/rdmavt/Kconfig | 1 +

Why do you need PCI for rdmavt?

> drivers/infiniband/ulp/ipoib/Kconfig | 1 +
> 9 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 234fe01..568088a 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -1,6 +1,5 @@
> menuconfig INFINIBAND
> tristate "InfiniBand support"
> - depends on PCI || BROKEN

By the way, do you know why are we dependent on BROKEN?

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]