From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH iproute2 3/5] rdma: Add device capability parsing Date: Mon, 26 Jun 2017 12:29:24 -0600 Message-ID: <20170626182924.GB16026@obsidianresearch.com> References: <20170626182128.24964-1-leon@kernel.org> <20170626182128.24964-4-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170626182128.24964-4-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Stephen Hemminger , Leon Romanovsky , Doug Ledford , Ariel Almog , Dennis Dalessandro , Linux RDMA , Linux Netdev List-Id: linux-rdma@vger.kernel.org On Mon, Jun 26, 2017 at 09:21:26PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Add parsing interface for the device capability flags > > $ rdma dev show > 1: mlx5_0: caps 0x1257e1c26 This seems very un ip-like. I wouldn't show an undecoded hex value like that, it isn't really useful. > $ rdma dev show mlx5_4 caps > 5: mlx5_4: caps 0x1257e1c26 > Bit Description > 01 DEVICE_BAD_PKEY_CNTR > 02 DEVICE_BAD_QKEY_CNTR This table also seems un ip-like, the usual format is a list of words, I think. > $ rdma dev show mlx5_4 cap_flags > Unknown parameter 'caps_flags'. ? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html