From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 2/4] RDMA/netlink: Advertise IB subnet prefix Date: Wed, 28 Jun 2017 10:12:36 -0600 Message-ID: <20170628161236.GC28839@obsidianresearch.com> References: <20170628133445.16550-1-leon@kernel.org> <20170628133445.16550-3-leon@kernel.org> <20170628160251.GB14375@obsidianresearch.com> <20170628161020.GI1248@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170628161020.GI1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, Jun 28, 2017 at 07:10:20PM +0300, Leon Romanovsky wrote: > > Since the GUID is in host order I recommend making the subnet_prefix > > in host order too. > > > > At the very least, the comments beside anything not in host order > > should be 'be64' not u64 > > Those comments represent netlink types. It doesn't have be64. Then don't send b64 down netlink as a netlink u64 type? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html