Re: [PATCH rdma-next 2/4] RDMA/netlink: Advertise IB subnet prefix

Leon Romanovsky
2017-06-28T16:10:20Z

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

On Wed, Jun 28, 2017 at 10:02:51AM -0600, Jason Gunthorpe wrote:
> On Wed, Jun 28, 2017 at 04:34:43PM +0300, Leon Romanovsky wrote:
>
> > + /*
> > + * Subnet prefix (in host byte order)
> > + */
> > + RDMA_NLDEV_ATTR_SUBNET_PREFIX, /* u64 */
>
> I've always hated how random the be / host choices are in our API.

Agree

>
> Since the GUID is in host order I recommend making the subnet_prefix
> in host order too.
>
> At the very least, the comments beside anything not in host order
> should be 'be64' not u64

Those comments represent netlink types. It doesn't have be64.

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]