Re: [PATCH rdma-next 3/4] RDMA/netink: Export lids and sm_lids

Jason Gunthorpe
2017-06-28T16:05:13Z

On Wed, Jun 28, 2017 at 04:34:44PM +0300, Leon Romanovsky wrote:
> + if (nla_put_u32(msg, RDMA_NLDEV_ATTR_LID, attr.lid))
> + return -EMSGSIZE;
> + if (nla_put_u32(msg, RDMA_NLDEV_ATTR_SM_LID, attr.sm_lid))
> + return -EMSGSIZE;

Is this careful to only stuff attributes if they actuall exists? Eg
these should not be present for iwarp/roce/etc

Same comment for all attributes. Only present if they are valid.

Jason