Re: [PATCH rdma-next 2/4] RDMA/netlink: Advertise IB subnet prefix

Jason Gunthorpe
2017-06-28T16:02:51Z

On Wed, Jun 28, 2017 at 04:34:43PM +0300, Leon Romanovsky wrote:

> + /*
> + * Subnet prefix (in host byte order)
> + */
> + RDMA_NLDEV_ATTR_SUBNET_PREFIX, /* u64 */

I've always hated how random the be / host choices are in our API.

Since the GUID is in host order I recommend making the subnet_prefix
in host order too.

At the very least, the comments beside anything not in host order
should be 'be64' not u64

Jason