Re: [PATCH rdma-next 3/4] RDMA/netink: Export lids and sm_lids

Leon Romanovsky
2017-06-28T16:16:16Z

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On Wed, Jun 28, 2017 at 10:05:13AM -0600, Jason Gunthorpe wrote:
> On Wed, Jun 28, 2017 at 04:34:44PM +0300, Leon Romanovsky wrote:
> > + if (nla_put_u32(msg, RDMA_NLDEV_ATTR_LID, attr.lid))
> > + return -EMSGSIZE;
> > + if (nla_put_u32(msg, RDMA_NLDEV_ATTR_SM_LID, attr.sm_lid))
> > + return -EMSGSIZE;
>
> Is this careful to only stuff attributes if they actuall exists? Eg
> these should not be present for iwarp/roce/etc
>
> Same comment for all attributes. Only present if they are valid.

It will be zero if it is not exist, but you are right it is better to
avoid to fill unneeded fields.

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]