From: Leon Romanovsky <leonro@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Doug Ledford <dledford@redhat.com>,
Ariel Almog <ariela@mellanox.com>,
Linux RDMA <linux-rdma@vger.kernel.org>,
Linux Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2 V3 2/4] rdma: Add dev object
Date: Tue, 4 Jul 2017 12:04:41 +0300 [thread overview]
Message-ID: <20170704090441.GF1528@mtr-leonro.local> (raw)
In-Reply-To: <20170704075541.12544-3-leon@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On Tue, Jul 04, 2017 at 10:55:39AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
> Device (dev) object represents struct ib_device to the user space.
>
> Device properties:
> * Device capabilities
> * FW version to the device output
> * node_guid and sys_image_guid
> * node_type
>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
<...>
> +}
> +
> +static void dev_print_node_type(struct nlattr **tb)
> +{
> + uint8_t node_type;
> + /*
> + * FIXME: move to index exported by the kernel
> + */
> + static const char *str[] = {
> + "UNKNOWN",
> + "SWITCH",
> + "ROUTER",
> + "RNIC",
> + "USNIC",
> + "USNIC_UDP",
> + };
There is a bug here, i forgot to add "CA" to the list of node_types
(before SWITCH). Thanks to Or Gerlitz who spotted it.
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-07-04 9:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 7:55 [PATCH iproute2 V3 0/4] RDMAtool Leon Romanovsky
2017-07-04 7:55 ` [PATCH iproute2 V3 1/4] rdma: Add basic infrastructure for RDMA tool Leon Romanovsky
2017-07-10 7:47 ` Jiri Pirko
2017-07-11 7:23 ` Leon Romanovsky
2017-07-04 7:55 ` [PATCH iproute2 V3 2/4] rdma: Add dev object Leon Romanovsky
2017-07-04 9:04 ` Leon Romanovsky [this message]
[not found] ` <20170704075541.12544-3-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-10 8:01 ` Jiri Pirko
2017-07-11 7:22 ` Leon Romanovsky
2017-07-04 7:55 ` [PATCH iproute2 V3 3/4] rdma: Add link object Leon Romanovsky
2017-07-10 8:13 ` Jiri Pirko
2017-07-10 16:22 ` Leon Romanovsky
2017-07-10 18:28 ` Jiri Pirko
2017-07-11 6:33 ` Leon Romanovsky
2017-07-10 7:43 ` [PATCH iproute2 V3 0/4] RDMAtool Jiri Pirko
2017-07-11 7:09 ` Leon Romanovsky
[not found] ` <20170704075541.12544-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-04 7:55 ` [PATCH iproute2 V3 4/4] rdma: Add initial manual for the tool Leon Romanovsky
2017-07-10 8:02 ` [PATCH iproute2 V3 0/4] RDMAtool Jiri Pirko
2017-07-10 16:01 ` Leon Romanovsky
2017-07-10 18:29 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704090441.GF1528@mtr-leonro.local \
--to=leonro@mellanox.com \
--cc=ariela@mellanox.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox