Re: [bug report] IB/mlx5: Respect mlx5_core reserved GIDs

[Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On Thu, Jul 06, 2017 at 01:38:11PM +0300, Leon Romanovsky wrote:
> On Thu, Jul 06, 2017 at 12:39:24PM +0300, Dan Carpenter wrote:
> > Hello Ilan Tayari,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 095b0927f0ce: "IB/mlx5: Respect mlx5_core reserved GIDs"
> > from May 14, 2017, leads to the following Smatch complaint:
> >
> > drivers/infiniband/hw/mlx5/main.c:327 set_roce_addr()
> > 	 error: we previously assumed 'gid' could be null (see line 300)
> >
> > drivers/infiniband/hw/mlx5/main.c
> >    299
> >    300		if (gid) {
> >                     ^^^
> > Before we used to return early if gid was NULL.
> 
> Thanks Dan,
> It is bug.
> mlx5_ib_del_gid calls this function with gid == NULL.
> 
>  363 static int mlx5_ib_del_gid(struct ib_device *device, u8 port_num,
>  364                            unsigned int index, __always_unused void **context)
>  365 {
>  366         return set_roce_addr(device, port_num, index, NULL, NULL);
>  367 }
> 

Hm...  You're right.  Btw, that code also generates a static checker
warning, but I just hadn't got around to reporting it yet.

	drivers/infiniband/hw/mlx5/main.c:342 mlx5_ib_del_gid()
	error: NULL dereference inside function.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html