From: Shiraz Saleem <shiraz.saleem@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Faisal Latif <faisal.latif@intel.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] IB/i40iw: Fix error code in i40iw_create_cq()
Date: Thu, 13 Jul 2017 09:42:39 -0500 [thread overview]
Message-ID: <20170713144239.GA856@ssaleem-MOBL4.amr.corp.intel.com> (raw)
In-Reply-To: <20170713074722.ki7o5k5vvdjbzpff@mwanda>
On Thu, Jul 13, 2017 at 10:47:22AM +0300, Dan Carpenter wrote:
> We accidentally forgot to set the error code if ib_copy_from_udata()
> fails. It means we return ERR_PTR(0) which is NULL and results in a
> NULL dereference in the callers.
>
> Fixes: d37498417947 ("i40iw: add files for iwarp interface")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_verbs.c b/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> index 4dbe61ec7a77..91f1631ff32d 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_verbs.c
> @@ -1161,8 +1161,10 @@ static struct ib_cq *i40iw_create_cq(struct ib_device *ibdev,
> memset(&req, 0, sizeof(req));
> iwcq->user_mode = true;
> ucontext = to_ucontext(context);
> - if (ib_copy_from_udata(&req, udata, sizeof(struct i40iw_create_cq_req)))
> + if (ib_copy_from_udata(&req, udata, sizeof(struct i40iw_create_cq_req))) {
> + err_code = -EFAULT;
> goto cq_free_resources;
> + }
>
> spin_lock_irqsave(&ucontext->cq_reg_mem_list_lock, flags);
> iwpbl = i40iw_get_pbl((unsigned long)req.user_cq_buffer,
Nice catch. Thank you!
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
next prev parent reply other threads:[~2017-07-13 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 7:47 [PATCH] IB/i40iw: Fix error code in i40iw_create_cq() Dan Carpenter
2017-07-13 14:42 ` Shiraz Saleem [this message]
2017-07-22 17:27 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713144239.GA856@ssaleem-MOBL4.amr.corp.intel.com \
--to=shiraz.saleem@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox