public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Yonatan Cohen <yonatanc-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH rdma-next 1/2] IB/rxe: Fix kernel panic from skb destructor
Date: Sun, 23 Jul 2017 08:21:39 +0300	[thread overview]
Message-ID: <20170723052139.GZ3259@mtr-leonro.local> (raw)
In-Reply-To: <a99bd03b-ea1d-983f-f76a-4798baa55fd4-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

On Sat, Jul 22, 2017 at 01:14:26PM -0400, Doug Ledford wrote:
> On 6/22/2017 10:09 AM, Leon Romanovsky wrote:
> > From: Yonatan Cohen <yonatanc-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > In the time between rxe_send has finished and skb destructor
> > called, the QP's ref count might be 0, leading to a possible
> > QP destruction. This will lead to a kernel panic when the destructor
> > dereferences the QP.
> >
> > The operation of incrementing QP ref count at rxe_send and decrementing
> > from skb destructor will prevent this crash.
>
> This series has been applied to 4.13-rc, thanks.
>
> FWIW Leon, if you have a series, even if it's a short 2 patch series, I
> prefer a cover letter.  It doesn't need to be long, and can just be
> something like "I have two bug fixes for rxe in this series", but I
> dislike responding to a patch and saying I applied a series.

No problem, I'll do.

Thanks

>
> --
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>     GPG Key ID: B826A3330E572FDD
>     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
>




[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2017-07-23  5:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 14:09 [PATCH rdma-next 1/2] IB/rxe: Fix kernel panic from skb destructor Leon Romanovsky
     [not found] ` <20170622141000.9899-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-22 14:10   ` [PATCH rdma-next 2/2] IB/rxe: Set dma_mask and coherent_dma_mask Leon Romanovsky
     [not found]     ` <20170622141000.9899-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-22 14:18       ` Johannes Thumshirn
2017-06-27 10:04       ` Yuval Shaia
2017-07-03 15:55         ` Moni Shoua
2017-06-22 14:18   ` [PATCH rdma-next 1/2] IB/rxe: Fix kernel panic from skb destructor Johannes Thumshirn
2017-07-22 17:14   ` Doug Ledford
     [not found]     ` <a99bd03b-ea1d-983f-f76a-4798baa55fd4-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-23  5:21       ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170723052139.GZ3259@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=yonatanc-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox