Re: [PATCH for-next 7/9] IB/core: Allow QP state transition from reset to error

Leon Romanovsky
2017-07-23T07:41:53Z

[-- Attachment #1: Type: text/plain, Size: 2008 bytes --]

On Sun, Jul 23, 2017 at 10:39:05AM +0300, Leon Romanovsky wrote:
> On Tue, May 30, 2017 at 08:46:09AM +0300, Leon Romanovsky wrote:
> > On Mon, May 29, 2017 at 05:20:53PM -0700, Dennis Dalessandro wrote:
> > > From: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > >
> > > Playing with IP-O-IB interface can trigger a warning message:
> > > "ib0: Failed to modify QP to ERROR state" to be logged.
> > > This happens when the QP is in IB_QPS_RESET state and the stack
> > > is trying to transition it to IB_QPS_ERR state in ipoib_ib_dev_stop().
> > >
> > > According to the IB spec, Table 91 - "QP State Transition Properties"
> > > it looks like the transition from reset to error is valid:
> > >
> > > Transition: Any State to Error
> > > Required Attributes: None
> > > Optional Attributes: None allowed
> > > Actions: Queue processing is stopped. Work Requests pending or in
> > > process are completed in error, when possible.
> > >
> > > This patch allows the transition and quiets the message.
> > >
> > > Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > ---
> >
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> Doug,
>
> After digging more with Erez's help, it looks like the sentence "it
> looks like the transition from reset to error is valid:" is not correct.
>
> According to the InfiniBandTM Architecture Release 1.3, Figure 126 QP/EE Context
> State Diagram - transition to error from reset is not valid.
>
> The quote from the spec:
> "An error can be forced from any state, except Reset, with the Modify QP/EE Verb."
>
> I'll send revert patch along with proper fix.

Ahh, it wasn't pushed to kernel.org, so no need to revert and you can
simply drop it.

Thanks

>
> Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]