From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
Cc: "notifications-9UaJU3cA/F/QT0dZR+AlfA@public.gmane.org"
<notifications-9UaJU3cA/F/QT0dZR+AlfA@public.gmane.org>,
"jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org"
<benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Subject: Re: [PATCH rdma-core 16/21] srp_daemon: Do not use LOG_PERROR
Date: Tue, 25 Jul 2017 11:44:41 -0600 [thread overview]
Message-ID: <20170725174441.GB10905@obsidianresearch.com> (raw)
In-Reply-To: <1501003688.8931.6.camel-Sjgp3cTcYWE@public.gmane.org>
On Tue, Jul 25, 2017 at 05:28:10PM +0000, Bart Van Assche wrote:
> On Tue, 2017-07-25 at 11:17 -0600, Jason Gunthorpe wrote:
> > On Tue, Jul 25, 2017 at 04:47:59PM +0000, Bart Van Assche wrote:
> > > LOG_PERROR is very convenient when debugging srp_daemon. How about using
> > > the result of isatty(STDERR_FILENO) to decide whether or not to enable
> > > LOG_PERROR?
> >
> > How about a --debug option that sets
> >
> > s_log_dest = log_to_stderr;
>
> Sorry but I prefer that LOG_PERROR is retained when srp_daemon is started in
> another way than by systemd. How about adding StandardError=null to the
> srp_daemon unit file?
No, then emergency prints from libraries are lost forever eg glibc
malloc corruption prints.
How about a --systemd option? I think we are going to want that anyhow
down the road.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-07-25 17:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 20:00 [PATCH rdma-core 00/21] Fixes for packaging Jason Gunthorpe
[not found] ` <1500926429-31822-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-24 20:00 ` [PATCH rdma-core 01/21] srp: Fix redhat packaging Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 02/21] cbuild: Switch to Fedora Core 26 Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 03/21] cbuild: Add debian stretch Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 04/21] cbuild: Use opensuse leap 42.2 Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 05/21] Make 'cbuild travis pkg' run sparse like real travis Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 06/21] Tidy travis sparse check Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 07/21] redhat: Fix redhat packaging of /etc/rdma/ibacm_opts.cfg Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 08/21] redhat: Fix duplicated udev rules in redhat packaging Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 09/21] redhat: Fix duplicated libmlx*.so " Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 10/21] debian: Set the run directory path to /run/ Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 11/21] debian: Remove infiniband-diags Depends from iwpmd Jason Gunthorpe
[not found] ` <1500926429-31822-12-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-27 13:37 ` Benjamin Drung
2017-07-24 20:00 ` [PATCH rdma-core 12/21] debian: Move truescale setup into rdma-core Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 13/21] Prefix udev rules with a number Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 14/21] Revise the umad SYSTEMD_ALIAS fake path Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 15/21] umad: Match only umad kernel devices in the udev rule Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 16/21] srp_daemon: Do not use LOG_PERROR Jason Gunthorpe
[not found] ` <1500926429-31822-17-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-25 16:47 ` Bart Van Assche
[not found] ` <1501001276.8931.1.camel-Sjgp3cTcYWE@public.gmane.org>
2017-07-25 17:17 ` Jason Gunthorpe
[not found] ` <20170725171735.GC3164-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-25 17:28 ` Bart Van Assche
[not found] ` <1501003688.8931.6.camel-Sjgp3cTcYWE@public.gmane.org>
2017-07-25 17:44 ` Jason Gunthorpe [this message]
[not found] ` <20170725174441.GB10905-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-25 18:09 ` Bart Van Assche
[not found] ` <1501006185.8931.7.camel-Sjgp3cTcYWE@public.gmane.org>
2017-07-25 23:08 ` Jason Gunthorpe
[not found] ` <20170725230802.GA20499-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-25 23:50 ` Bart Van Assche
[not found] ` <1501026650.8931.11.camel-Sjgp3cTcYWE@public.gmane.org>
2017-07-26 16:37 ` Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 17/21] srp_deamon: Using v formatters directly for pr_err Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 18/21] srp_daemon: Call systemctl properly from udev Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 19/21] iwpmd: Fix install path for iwpmd Jason Gunthorpe
2017-07-24 20:00 ` [PATCH rdma-core 20/21] Move rxe_cfg to the rdma-core package Jason Gunthorpe
[not found] ` <1500926429-31822-21-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-07-27 13:57 ` Benjamin Drung
2017-07-24 20:00 ` [PATCH rdma-core 21/21] Make /etc/modprobe.d/mlx4.conf common Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725174441.GB10905@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org \
--cc=benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=notifications-9UaJU3cA/F/QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox