From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH rdma-next] IB/cma: Set default gid type to RoCEv2 Date: Sun, 30 Jul 2017 09:12:00 +0300 Message-ID: <20170730061200.GL13672@mtr-leonro.local> References: <20170530064734.4731-1-leon@kernel.org> <20170607090750.GC1127@mtr-leonro.local> <1501264241.2593.21.camel@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cN519qCC4CN1mUcX" Return-path: Content-Disposition: inline In-Reply-To: <1501264241.2593.21.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Moni Shoua List-Id: linux-rdma@vger.kernel.org --cN519qCC4CN1mUcX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 28, 2017 at 01:50:41PM -0400, Doug Ledford wrote: > On Wed, 2017-06-07 at 12:07 +0300, Leon Romanovsky wrote: > > On Tue, May 30, 2017 at 09:47:34AM +0300, Leon Romanovsky wrote: > > > From: Moni Shoua > > > > > > RoCEv2 is the preferred RDMA protocol for Ethernet link layer > > > because > > > of its advantages over RoCEv1. For better user experience make it > > > the > > > default choice for RDMA_CM connections if device/port support it. > > > > > > Signed-off-by: Moni Shoua > > > Reviewed-by: Matan Barak > > > Signed-off-by: Leon Romanovsky > > > --- > > > drivers/infiniband/core/cma.c | 9 +++++++-- > > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/infiniband/core/cma.c > > > b/drivers/infiniband/core/cma.c > > > index 91b7a2fe5a55..5ce3c9e1657e 100644 > > > --- a/drivers/infiniband/core/cma.c > > > +++ b/drivers/infiniband/core/cma.c > > > @@ -72,6 +72,7 @@ MODULE_LICENSE("Dual BSD/GPL"); > > > #define CMA_MAX_CM_RETRIES 15 > > > #define CMA_CM_MRA_SETTING (IB_CM_MRA_FLAG_DELAY | 24) > > > #define CMA_IBOE_PACKET_LIFETIME 18 > > > +#define CMA_PREFERRED_ROCE_GID_TYPE IB_GID_TYPE_ROCE_UDP_ENCAP > > > > It should be (1 << IB_GID_TYPE_ROCE_UDP_ENCAP) and not as was written > > above. We will send a fix for that. > > I didn't see a followup that fixed this, so I took this patch and then > created a fix patch myself. Thanks. > > -- > Doug Ledford > GPG KeyID: B826A3330E572FDD > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --cN519qCC4CN1mUcX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAll9eLAACgkQ5GN7iDZy WKc1NQ//YT/elpuIjO4++Vlh2nAvmke3HmgoPofnaXqICCrD+Bkm8a4GGw8csnYj gC4HwE5Z4LNSjybcjUM40tpYAfrQeVpw7dRmmV4saGkUAy78GwIgYsChduZdIxI2 atR+Fem4rZCcikgGAfwZ0Pnqdp8F3vgN1pS1ezzWkYFIhF8RWeLmf14kat7OIR2f 3DsXleMLQe0L2NR94bQ7fjsU8aKGraO1RXf8AzIDAfesylV8sP7SeEEffdKE1Vpy 3qatv9lnMxDbWulM7zqNOPB0V8wb+iKBgQNd7LnJNym1I2pVSiPjobU28uQmubaU +GN2+9qrJl6aUD/njL4dVQWh2+JJigCp+Oyv3lXSAF5AdjXi4+BADkw+6u6aMEbL Y8rIOWFYXkdVzQ2f5LLNjUfFh6LZTFt1cCXEAiDFMk6ADG3EIbNS9gJUJKCiIFvR 9NDY118V3+2vPivT3q/DoQDZ+gCtspu/NoSaF+O8We6bFC8t0eVOrejAorPfklks HH8UlKTAMm199i/0tI6+ffmqGzxicNQTYEKje03K+AXJcSIz44iX9vXrdBUPU2F8 35taEATqqbgAlB0/QP2gUQtkMjjry7Jx40oA9RLTQm34gvIgy/L2Vwy9jpgEiNV2 WDR2wPQ3qx6zsDkeikcGo1sZzj4sxocluh5HtVGTAKTiOcIvMiY= =e3vQ -----END PGP SIGNATURE----- --cN519qCC4CN1mUcX-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html