linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [rdma-next 01/33] Revert "IB/core: Add flow control to the portmapper netlink calls"
Date: Tue,  1 Aug 2017 15:05:04 +0300	[thread overview]
Message-ID: <20170801120536.540-2-leon@kernel.org> (raw)
In-Reply-To: <20170801120536.540-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

The commit cea05eadded0 ("IB/core: Add flow control to the portmapper netlink calls")
changed netlink to be blocked for all RDMA clients. This workaround
worked perfectly for portmapper, but is not correct for the whole
NETLINK_RDMA family.

The request/response should always be blocking and asynchronous
notification should always be non-blocking.

It is library and user-space application to chose how to handle recvmgs,
as an example see nl_recvmsgs() and nl_socket_set_nonblocking() calls of
libnl library.

Send timeout is not needed too and can be configured with SO_SNDTIMEO socket
option.

This reverts commit cea05eadded0d4eb59f7be6e1f1560eb6bfde2bf.

Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/core/netlink.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c
index 94931c474d41..454d51e432db 100644
--- a/drivers/infiniband/core/netlink.c
+++ b/drivers/infiniband/core/netlink.c
@@ -230,10 +230,7 @@ static void ibnl_rcv(struct sk_buff *skb)
 int ibnl_unicast(struct sk_buff *skb, struct nlmsghdr *nlh,
 			__u32 pid)
 {
-	int err;
-
-	err = netlink_unicast(nls, skb, pid, 0);
-	return (err < 0) ? err : 0;
+	return nlmsg_unicast(nls, skb, pid);
 }
 EXPORT_SYMBOL(ibnl_unicast);
 
@@ -256,7 +253,6 @@ int __init ibnl_init(void)
 		return -ENOMEM;
 	}
 
-	nls->sk_sndtimeo = 10 * HZ;
 	return 0;
 }
 
-- 
2.13.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-08-01 12:05 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 12:05 [pull request][rdma-next 00/33] RDMA netlink refactoring and RDMAtool code Leon Romanovsky
     [not found] ` <20170801120536.540-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-01 12:05   ` Leon Romanovsky [this message]
     [not found]     ` <20170801120536.540-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-01 13:38       ` [rdma-next 01/33] Revert "IB/core: Add flow control to the portmapper netlink calls" Chien Tin Tung
     [not found]         ` <20170801133832.GA11812-TZeIlv3TuzOfrEmaQUPKxl95YUYmaKo1UNDiOz3kqAs@public.gmane.org>
2017-08-01 14:10           ` Leon Romanovsky
     [not found]             ` <20170801141023.GM13672-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-01 14:18               ` Chien Tin Tung
     [not found]                 ` <20170801141842.GA1808-TZeIlv3TuzOfrEmaQUPKxl95YUYmaKo1UNDiOz3kqAs@public.gmane.org>
2017-08-01 14:22                   ` Christopher Lameter
2017-08-01 15:13                     ` Leon Romanovsky
2017-08-01 15:15                     ` Chien Tin Tung
     [not found]                       ` <20170801151511.GA13376-TZeIlv3TuzOfrEmaQUPKxl95YUYmaKo1UNDiOz3kqAs@public.gmane.org>
2017-08-01 15:20                         ` Bart Van Assche
     [not found]                           ` <1501600807.2475.4.camel-Sjgp3cTcYWE@public.gmane.org>
2017-08-01 16:21                             ` Chien Tin Tung
     [not found]                               ` <20170801162135.GA240-TZeIlv3TuzOfrEmaQUPKxl95YUYmaKo1UNDiOz3kqAs@public.gmane.org>
2017-08-01 16:55                                 ` Bart Van Assche
     [not found]                                   ` <1501606508.2475.12.camel-Sjgp3cTcYWE@public.gmane.org>
2017-08-01 17:14                                     ` Chien Tin Tung
     [not found]                                       ` <20170801171454.GA8484-TZeIlv3TuzOfrEmaQUPKxl95YUYmaKo1UNDiOz3kqAs@public.gmane.org>
2017-08-01 17:28                                         ` Bart Van Assche
     [not found]                                           ` <1501608534.2475.14.camel-Sjgp3cTcYWE@public.gmane.org>
2017-08-01 17:52                                             ` Chien Tin Tung
     [not found]                                               ` <20170801175236.GA14048-TZeIlv3TuzOfrEmaQUPKxl95YUYmaKo1UNDiOz3kqAs@public.gmane.org>
2017-08-01 17:58                                                 ` Bart Van Assche
     [not found]                                                   ` <1501610305.2475.16.camel-Sjgp3cTcYWE@public.gmane.org>
2017-08-01 18:20                                                     ` Chien Tin Tung
2017-08-01 19:58                         ` Jason Gunthorpe
     [not found]                           ` <20170801195840.GC31205-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-01 20:38                             ` Chien Tin Tung
     [not found]                               ` <20170801203815.GA4620-TZeIlv3TuzOfrEmaQUPKxl95YUYmaKo1UNDiOz3kqAs@public.gmane.org>
2017-08-01 23:17                                 ` Jason Gunthorpe
2017-08-02  3:44                             ` Leon Romanovsky
     [not found]                               ` <20170802034438.GV13672-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-02 15:58                                 ` Jason Gunthorpe
     [not found]                                   ` <20170802155856.GA21208-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-02 16:29                                     ` Leon Romanovsky
     [not found]                                       ` <20170802162938.GC13672-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-02 16:45                                         ` Jason Gunthorpe
     [not found]                                           ` <20170802164553.GA31901-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-02 16:51                                             ` Bart Van Assche
     [not found]                                               ` <1501692660.2437.4.camel-Sjgp3cTcYWE@public.gmane.org>
2017-08-02 17:08                                                 ` Jason Gunthorpe
     [not found]                                                   ` <20170802170823.GA32513-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-02 17:11                                                     ` Bart Van Assche
     [not found]                                                       ` <1501693892.2437.6.camel-Sjgp3cTcYWE@public.gmane.org>
2017-08-02 17:20                                                         ` Jason Gunthorpe
2017-08-02 17:57               ` Doug Ledford
     [not found]                 ` <1501696661.109555.6.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-02 18:54                   ` Leon Romanovsky
     [not found]                     ` <20170802185405.GE13672-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-03  0:19                       ` Doug Ledford
     [not found]                         ` <1501719575.117042.4.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-03  5:10                           ` Leon Romanovsky
     [not found]                             ` <20170803051032.GF13672-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-03 12:22                               ` Doug Ledford
     [not found]                                 ` <1501762973.117042.7.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-03 12:42                                   ` Doug Ledford
     [not found]                                     ` <1501764159.117042.9.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-06  7:47                                       ` Leon Romanovsky
     [not found]                                         ` <20170806074751.GA3636-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-06 19:00                                           ` Bart Van Assche
2017-08-01 12:05   ` [rdma-next 02/33] RDMA/netlink: Remove netlink clients infrastructure Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 03/33] RDMA/netlink: Remove redundant owner option for netlink callbacks Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 04/33] RDMA/netlink: Avoid double pass for RDMA netlink messages Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 05/33] RDMA/iwcm: Remove useless check of nelink client validity Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 06/33] RDMA/iwcm: Remove extra EXPORT_SYMBOLS Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 07/33] RDMA/netlink: Add flag to consolidate common handing Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 08/33] RDMA/netlink: Simplify the put_msg and put_attr Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 09/33] RDMA/netlink: Rename and remove redundant parameter from ibnl_unicast Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 10/33] RDMA/netlink: Rename and remove redundant parameter from ibnl_multicast Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 11/33] RDMA/netlink: Simplify and rename ibnl_chk_listeners Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 12/33] RDMA/netlink: Rename netlink callback struct Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 13/33] RDMA/core: Add iterator over ib_devices Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 14/33] RDMA/core: Add and expose static device index Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 15/33] RDMA/netlink: Add and implement doit netlink callback Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 16/33] RDMA/netlink: Reduce indirection access to cb_table Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 17/33] RDMA/netlink: Convert LS to doit callback Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 18/33] RDMA/netlink: Update copyright Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 19/33] RDMA/netlink: Add netlink device definitions to UAPI Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 20/33] RDMA/netlink: Add nldev initialization flows Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 21/33] RDMA/netlink: Implement nldev device dumpit calback Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 22/33] RDMA/netlink: Add nldev device doit implementation Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 23/33] RDMA/netlink: Add nldev port dumpit implementation Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 24/33] RDMA/netlink: Implement nldev port doit callback Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 25/33] RDMA/netlink: Expose device and port capability masks Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 26/33] RDMA: Simplify get firmware interface Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 27/33] RDMA/netlink: Export FW version Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 28/33] RDMA/netlink: Export node_guid and sys_image_guid Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 29/33] RDMA/netlink: Advertise IB subnet prefix Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 30/33] RDMA/netink: Export lids and sm_lids Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 31/33] RDMA/netlink: Export LID mask control (LMC) Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 32/33] RDMA/netlink: Provide port state and physical link state Leon Romanovsky
2017-08-01 12:05   ` [rdma-next 33/33] RDMA/netlink: Export node_type Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801120536.540-2-leon@kernel.org \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).