linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: 'Nicolas Morey-Chaisemartin'
	<NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org>,
	'Leon Romanovsky' <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: rdma-core build environment enabling out-of-core providers
Date: Thu, 3 Aug 2017 08:47:33 -0600	[thread overview]
Message-ID: <20170803144733.GA13127@obsidianresearch.com> (raw)
In-Reply-To: <008401d30c5f$3c9e2560$b5da7020$@opengridcomputing.com>

On Thu, Aug 03, 2017 at 08:48:50AM -0500, Steve Wise wrote:

> > I 'm not sure I see the issue here (or at least nothing easily
> > fixed).  If the standard spec produces an extra
> > rdma-core-provider-devel with those headers, it's just a matter of
> > rebuilding the out-of-tree provider against the right
> > distro/package.
> 
> After thinking about this more, I agree: If rdma-core is built into
> binary platform and distro-specific rpms, then these header files
> are definitely available to export as a -devel rpm for that same
> platform/distro.

The issue is where do you put headers like stdatomic.h, config.h, etc.

These headers will collide with normal headers in various cases..

It is designed to be built with a private include/ that relies on
#include_next to make everything work out, you cannot just dump the
headers in /usr/include.

If instead you do something like /usr/share/rdma-core/include then you
still have the problem of conflicting with common user header names
like config.h, and the problem of being matched exactly to the
compiler that cmake was using when it made the headers.

Overall it is a very fragile approach..

There are also minor issues like actually building and linking the
provider correctly, there were many issues there pre-rdma-core,
building it outside the existing cmake framework means someone else
has to actually understand how to do this properly :)

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-08-03 14:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02 13:55 rdma-core build environment enabling out-of-core providers Steve Wise
2017-08-02 16:09 ` Jason Gunthorpe
     [not found]   ` <20170802160900.GB21208-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-02 19:16     ` Steve Wise
2017-08-02 19:34       ` Jason Gunthorpe
     [not found]         ` <20170802193403.GA23777-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-02 20:05           ` Steve Wise
2017-08-02 20:23             ` Jason Gunthorpe
     [not found]               ` <20170802202300.GA24244-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-03  5:26                 ` Leon Romanovsky
2017-08-03  7:08       ` Nicolas Morey-Chaisemartin
     [not found]         ` <44b511c6-45fa-d5aa-4d4c-e47d2edcf604-l3A5Bk7waGM@public.gmane.org>
2017-08-03 13:48           ` Steve Wise
2017-08-03 14:47             ` Jason Gunthorpe [this message]
     [not found]               ` <20170803144733.GA13127-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-03 15:01                 ` Nicolas Morey-Chaisemartin
     [not found]                   ` <890f961c-7aa8-1a73-e98d-f7ce9da333d7-l3A5Bk7waGM@public.gmane.org>
2017-08-03 17:07                     ` Jason Gunthorpe
     [not found]                       ` <20170803170713.GD13127-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-04  6:02                         ` Nicolas Morey-Chaisemartin
     [not found]                           ` <7cc0ba31-7a05-4db1-5807-4d971fc3d773-l3A5Bk7waGM@public.gmane.org>
2017-08-04 11:30                             ` Steve Wise
2017-08-04 11:52                               ` Nicolas Morey-Chaisemartin
     [not found]                                 ` <188beb70-9776-33fc-6f72-cc00e968db73-l3A5Bk7waGM@public.gmane.org>
2017-08-04 13:14                                   ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170803144733.GA13127@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).