From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH for-next 12/27] IB/core: Change port_attr.sm_lid from 16 to 32 bits Date: Sun, 6 Aug 2017 11:18:57 +0300 Message-ID: <20170806081857.GC3636@mtr-leonro.local> References: <20170804204842.17853.14858.stgit@scvm10.sc.intel.com> <20170804205320.17853.77236.stgit@scvm10.sc.intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c3bfwLpm8qysLVxt" Return-path: Content-Disposition: inline In-Reply-To: <20170804205320.17853.77236.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dennis Dalessandro Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Don Hiatt , Ira Weiny , Dasaratharaman Chandramouli List-Id: linux-rdma@vger.kernel.org --c3bfwLpm8qysLVxt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 04, 2017 at 01:53:21PM -0700, Dennis Dalessandro wrote: > From: Dasaratharaman Chandramouli > > sm_lid field in struct ib_port_attr is increased to 32 bits. This > enables core components to use larger LIDs if needed. > The user ABI is unchanged and return 16 bit values when queried. > > Signed-off-by: Dasaratharaman Chandramouli > Reviewed-by: Ira Weiny > Signed-off-by: Don Hiatt > Signed-off-by: Dennis Dalessandro > --- > drivers/infiniband/core/uverbs_cmd.c | 8 +++++--- > include/rdma/ib_verbs.h | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c > index 7ef74b0..38dce45 100644 > --- a/drivers/infiniband/core/uverbs_cmd.c > +++ b/drivers/infiniband/core/uverbs_cmd.c > @@ -275,11 +275,13 @@ ssize_t ib_uverbs_query_port(struct ib_uverbs_file *file, > resp.bad_pkey_cntr = attr.bad_pkey_cntr; > resp.qkey_viol_cntr = attr.qkey_viol_cntr; > resp.pkey_tbl_len = attr.pkey_tbl_len; > - resp.sm_lid = attr.sm_lid; > - if (rdma_cap_opa_ah(ib_dev, cmd.port_num)) > + if (rdma_cap_opa_ah(ib_dev, cmd.port_num)) { > resp.lid = OPA_TO_IB_UCAST_LID(attr.lid); > - else > + resp.sm_lid = OPA_TO_IB_UCAST_LID(attr.sm_lid); > + } else { > resp.lid = (u16)attr.lid; > + resp.sm_lid = (u16)attr.sm_lid; I see that lid is already has casting from u32 to u16 and now it is sm_lid. Do we have more elegant way to achieve that? And comment for future developers can be good too. > + } > resp.lmc = attr.lmc; > resp.max_vl_num = attr.max_vl_num; > resp.sm_sl = attr.sm_sl; > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index 4eccf89..5f4f2d3 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -549,7 +549,7 @@ struct ib_port_attr { > u32 bad_pkey_cntr; > u32 qkey_viol_cntr; > u16 pkey_tbl_len; > - u16 sm_lid; > + u32 sm_lid; > u32 lid; > u8 lmc; > u8 max_vl_num; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --c3bfwLpm8qysLVxt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlmG0PEACgkQ5GN7iDZy WKcqLxAAvR0ce3EviWVtWWlytw8npsr8TSSC44CnybEE0xVKToH5SmSrwmkqdqw4 phzI02RmIfDMzoGdC51rVDVY/uhqXtzQR7iGD430M39+7ll/pibfGRY4E/lt3fG5 FeMwjAdu1veJnKtQU9Mi4JF5jH9ViCtUxW6gWI1CmDbWe3WIHppFYlpOrbx8+m+q lunVV9bgZ7pALXws0emltD/QD+GaX8Rke/sGLAbOIUv6fSOSzjl2ya0u4OkJuIoB DwCk2JQxQJED2hL5jHoFNuxunKI+l/0wLYZmLz1DTj133b7qBfUE7U01GHxF3XnD s6gkK3z6tZD5rWiPopJh9rlf6xrCdz7EQ1vTbGRRUV3HGzyydls++W4XRB2yPpQU QzhroW8vVDlvGdki4L6dGWfsU1S7taqKMop9EgKPt9iyJ1CbGk8l+tW5tx05embh CdSezLtUU1+jLLrdXApXdWBwal2dPmQluWZOKPyYEDUcug0ZDlZwmkd1S82h3pjh IpiGR1ZODb1dubhTzLEZw7nZupNvXCdaWquwVBgYVdTeCYu8pfsPt/f3f/Iaux43 jwwCcNNtcV3Og+DdkXVl4vwsKr4EfanIxOiIjHvzCK3hwHjo2p5R20pfR9dkuBBC DjMBMJSfHEc1616y8TB+ilBg2/pGNftaMIEuNc2aTv9ht0M8IoY= =nzXo -----END PGP SIGNATURE----- --c3bfwLpm8qysLVxt-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html