Re: [PATCH] verbs: Change the provider library file name suffix

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]

On Wed, Aug 09, 2017 at 03:54:00PM -0600, Jason Gunthorpe wrote:
> This should have been changed when the private provider API was
> introduced..
>
> The intent of the 'rdmav2' suffix was to indicate the provider is ABI
> compatible with the libibverbs loading it, with the new scheme the only
> providers which are compatible have the same ABI private version.
>
> Change the suffix to be rdmav15 to match the current private version,
> and set things up to be able to track the map file/etc.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> ---
>  CMakeLists.txt                   |  5 +++++
>  buildlib/check-build             | 36 +++++++++++++++++++++++++++++++-----
>  buildlib/config.h.in             |  1 +
>  buildlib/rdma_functions.cmake    | 10 +++++-----
>  debian/ibverbs-providers.install |  2 +-
>  libibverbs/driver.h              |  7 -------
>  libibverbs/ibverbs.h             |  2 --
>  libibverbs/init.c                | 13 +++++--------
>  8 files changed, 48 insertions(+), 28 deletions(-)
>
> This will help Steve Wise out in his goal to make out of tree provider
> modules..
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 617b3f5b01b077..2324cf49aff5a8 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -45,6 +45,11 @@ set(PACKAGE_NAME "RDMA")
>
>  # See Documentation/versioning.md
>  set(PACKAGE_VERSION "15")
> +# When this is changed the values in these files need changing too:
> +#   debian/libibverbs1.symbols
> +#   libibverbs/libibverbs.map
> +set(IBVERBS_PABI_VERSION "15")

The overall change looks fine to me, but the lines above worry me - Addition of new "set" instruction
can be prone for errors, because it is not clear when it should be updated.

What do you think if we update it automatically?

Something like that:
➜  rdma-core git:(master) ✗ grep -e "^IBVERBS_PRIVATE_" libibverbs/libibverbs.map | cut -d'_' -f3 |  awk '{ print $1}' | sort | tail -n 1

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]