public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Selvin Xavier <selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Somnath Kotur
	<somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH for-next] IB/cma: Fix gid type setting for RoCE
Date: Fri, 11 Aug 2017 12:38:38 +0300	[thread overview]
Message-ID: <20170811093838.GC24282@mtr-leonro.local> (raw)
In-Reply-To: <1502442585-22391-1-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On Fri, Aug 11, 2017 at 02:09:45AM -0700, Selvin Xavier wrote:
> RoCE gid_type should be 0 or 1 based on RoCE v1 or
> RoCE V2. Since bit mask is used now, cma_dev->default_gid_type
> is set to 2 (1 << IB_GID_TYPE_ROCE_UDP_ENCAP).
> Use the bit mask to check the prefered gid_type and
> assign the gid_type value to IB_GID_TYPE_ROCE(0) or
> IB_GID_TYPE_ROCE_UDP_ENCAP(1).
>
> Fixes: 3c7f67d1880d (IB/cma: Fix default RoCE type setting)
> Signed-off-by: Selvin Xavier <selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Somnath Kotur <somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> ---
>  drivers/infiniband/core/cma.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>

Hi Selvin,

We tested a little bit simple version of this fix.
https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/commit/?h=rdma-next&id=bf01e3dda415538fcb799bebfe60053cf6154490

Thanks,

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-08-11  9:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-11  9:09 [PATCH for-next] IB/cma: Fix gid type setting for RoCE Selvin Xavier
     [not found] ` <1502442585-22391-1-git-send-email-selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-08-11  9:38   ` Leon Romanovsky [this message]
     [not found]     ` <20170811093838.GC24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-11  9:56       ` Selvin Xavier
     [not found]         ` <CA+sbYW2RpmGMyf0sYwPsNrmjYUjE1rm+R-RGGj1N4PPS1im29Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-11 10:18           ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170811093838.GC24282@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox