From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [rdma-next 07/22] RDMA/core: Remove unimplemented node_types and node transport
Date: Fri, 11 Aug 2017 13:49:48 +0300 [thread overview]
Message-ID: <20170811105003.7661-8-leon@kernel.org> (raw)
In-Reply-To: <20170811105003.7661-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
There is no need to carry code, which is not implemented in any
underlying hardware. This patch removes unimplemented node_types and
their respective node transport layers.
Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
drivers/infiniband/core/sysfs.c | 3 ---
drivers/infiniband/core/verbs.c | 5 -----
include/rdma/ib_verbs.h | 16 ++++++----------
3 files changed, 6 insertions(+), 18 deletions(-)
diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index abc5ab581f82..c43280f8d5b3 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -1146,10 +1146,7 @@ static ssize_t show_node_type(struct device *device,
switch (dev->node_type) {
case RDMA_NODE_IB_CA: return sprintf(buf, "%d: CA\n", dev->node_type);
case RDMA_NODE_RNIC: return sprintf(buf, "%d: RNIC\n", dev->node_type);
- case RDMA_NODE_USNIC: return sprintf(buf, "%d: usNIC\n", dev->node_type);
case RDMA_NODE_USNIC_UDP: return sprintf(buf, "%d: usNIC UDP\n", dev->node_type);
- case RDMA_NODE_IB_SWITCH: return sprintf(buf, "%d: switch\n", dev->node_type);
- case RDMA_NODE_IB_ROUTER: return sprintf(buf, "%d: router\n", dev->node_type);
default: return sprintf(buf, "%d: <unknown>\n", dev->node_type);
}
}
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 3d1de62de839..21fef6b6d4f3 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -182,13 +182,9 @@ rdma_node_get_transport(enum rdma_node_type node_type)
{
switch (node_type) {
case RDMA_NODE_IB_CA:
- case RDMA_NODE_IB_SWITCH:
- case RDMA_NODE_IB_ROUTER:
return RDMA_TRANSPORT_IB;
case RDMA_NODE_RNIC:
return RDMA_TRANSPORT_IWARP;
- case RDMA_NODE_USNIC:
- return RDMA_TRANSPORT_USNIC;
case RDMA_NODE_USNIC_UDP:
return RDMA_TRANSPORT_USNIC_UDP;
default:
@@ -207,7 +203,6 @@ enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 port_
case RDMA_TRANSPORT_IB:
return IB_LINK_LAYER_INFINIBAND;
case RDMA_TRANSPORT_IWARP:
- case RDMA_TRANSPORT_USNIC:
case RDMA_TRANSPORT_USNIC_UDP:
return IB_LINK_LAYER_ETHERNET;
default:
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 6cd2b91b8fc8..7aabec3a8a19 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -95,12 +95,9 @@ struct ib_gid_attr {
enum rdma_node_type {
/* IB values map to NodeInfo:NodeType. */
- RDMA_NODE_IB_CA = 1,
- RDMA_NODE_IB_SWITCH,
- RDMA_NODE_IB_ROUTER,
- RDMA_NODE_RNIC,
- RDMA_NODE_USNIC,
- RDMA_NODE_USNIC_UDP,
+ RDMA_NODE_IB_CA = 1,
+ RDMA_NODE_RNIC = 4,
+ RDMA_NODE_USNIC_UDP = 6,
};
enum {
@@ -109,10 +106,9 @@ enum {
};
enum rdma_transport_type {
- RDMA_TRANSPORT_IB,
- RDMA_TRANSPORT_IWARP,
- RDMA_TRANSPORT_USNIC,
- RDMA_TRANSPORT_USNIC_UDP
+ RDMA_TRANSPORT_IB = 0,
+ RDMA_TRANSPORT_IWARP = 1,
+ RDMA_TRANSPORT_USNIC_UDP = 3,
};
enum rdma_protocol_type {
--
2.14.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-11 10:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 10:49 [pull request][rdma-next 00/22] RDMA core, drivers and IPoIB fixes Leon Romanovsky
[not found] ` <20170811105003.7661-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-11 10:49 ` [rdma-next 01/22] IB/cma: Fix erroneous validation of supported default GID type Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 02/22] IB/uverbs: Introduce and use helper functions to copy ah attributes Leon Romanovsky
[not found] ` <20170811105003.7661-3-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-11 12:15 ` Dennis Dalessandro
2017-08-11 10:49 ` [rdma-next 03/22] RDMA/mlx4: Don't use uninitialized variable Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 04/22] RDMA/mlx4: Fix create qp command alignment Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 05/22] RDMA/(core,ulp): Convert register/unregister event handler to be void Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 06/22] RDMA/core: Cleanup device capability enum Leon Romanovsky
2017-08-11 10:49 ` Leon Romanovsky [this message]
[not found] ` <20170811105003.7661-8-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-11 12:32 ` [rdma-next 07/22] RDMA/core: Remove unimplemented node_types and node transport Dennis Dalessandro
2017-08-11 16:46 ` Hal Rosenstock
[not found] ` <36aea320-a018-040d-c44a-3a23d54771cd-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-08-11 18:13 ` Dennis Dalessandro
[not found] ` <72f3047f-8b29-435d-57bf-be0734606368-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-12 6:32 ` Leon Romanovsky
2017-08-11 18:13 ` Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 08/22] RDMA/core: Delete BUG() from unreachable flow Leon Romanovsky
[not found] ` <20170811105003.7661-9-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-13 10:21 ` Yuval Shaia
2017-08-13 10:29 ` Leon Romanovsky
[not found] ` <20170813102904.GV24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-13 10:51 ` Yuval Shaia
2017-08-13 11:00 ` Leon Romanovsky
[not found] ` <20170813110017.GX24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-13 11:08 ` Yuval Shaia
2017-08-11 10:49 ` [rdma-next 09/22] RDMA/core: Refactor get link layer wrapper Leon Romanovsky
[not found] ` <20170811105003.7661-10-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-13 10:13 ` Yuval Shaia
2017-08-11 10:49 ` [rdma-next 10/22] RDMA/mlx4: Remove gfp_mask argument from acquire_group call Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 11/22] RDMA/usnic: Fix remove address space warning Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 12/22] RDMA/mthca: Make explicit conversion to 64bit value Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 13/22] RDMA/hns: Remove empty functions Leon Romanovsky
[not found] ` <20170811105003.7661-14-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-11 12:26 ` Dennis Dalessandro
[not found] ` <fe444f34-ec1e-a5bb-34cb-0c34499d1e21-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-15 3:36 ` oulijun
2017-08-11 10:49 ` [rdma-next 14/22] IB/mlx4: Fix some spelling mistakes Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 15/22] IB/mlx5: " Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 16/22] IB/mlx5: Add necessary delay drop assignment Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 17/22] IB/mlx4: Fix RSS QP type in creation verb Leon Romanovsky
2017-08-11 10:49 ` [rdma-next 18/22] IB/mlx4: Fix struct mlx4_ib_create_wq alignment Leon Romanovsky
2017-08-11 10:50 ` [rdma-next 19/22] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct Leon Romanovsky
[not found] ` <20170811105003.7661-20-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-13 9:07 ` Yuval Shaia
2017-08-13 9:43 ` Leon Romanovsky
2017-08-11 10:50 ` [rdma-next 20/22] IB/mlx4: Check that reserved fields in mlx4_ib_create_qp_rss are zero Leon Romanovsky
[not found] ` <20170811105003.7661-21-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-13 9:17 ` Yuval Shaia
2017-08-13 9:58 ` Leon Romanovsky
2017-08-11 10:50 ` [rdma-next 21/22] IB/ipoib: Sync between remove_one to sysfs calls that use rtnl_lock Leon Romanovsky
2017-08-11 10:50 ` [rdma-next 22/22] IB/ipoib: Add get statistics support to SRIOV VF Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811105003.7661-8-leon@kernel.org \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox