public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [rdma-next 19/22] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct
Date: Sun, 13 Aug 2017 12:07:46 +0300	[thread overview]
Message-ID: <20170813090745.GE3924@yuvallap> (raw)
In-Reply-To: <20170811105003.7661-20-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

On Fri, Aug 11, 2017 at 01:50:00PM +0300, Leon Romanovsky wrote:
> From: Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> rss_key_len is not in use and need to be removed.
> 
> Fixes: 3078f5f1bd8b ("IB/mlx4: Add support for RSS QP")
> Signed-off-by: Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
>  include/uapi/rdma/mlx4-abi.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/uapi/rdma/mlx4-abi.h b/include/uapi/rdma/mlx4-abi.h
> index 0e10102861b5..c55f60e05f86 100644
> --- a/include/uapi/rdma/mlx4-abi.h
> +++ b/include/uapi/rdma/mlx4-abi.h
> @@ -98,8 +98,7 @@ struct mlx4_ib_create_srq_resp {
>  struct mlx4_ib_create_qp_rss {
>  	__u64   rx_hash_fields_mask;
>  	__u8    rx_hash_function;
> -	__u8    rx_key_len;
> -	__u8    reserved[6];
> +	__u8    reserved[7];

Looks like this change is not explained in commit message.

>  	__u8    rx_hash_key[40];
>  	__u32   comp_mask;
>  	__u32   reserved1;
> -- 
> 2.14.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-08-13  9:07 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-11 10:49 [pull request][rdma-next 00/22] RDMA core, drivers and IPoIB fixes Leon Romanovsky
     [not found] ` <20170811105003.7661-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-11 10:49   ` [rdma-next 01/22] IB/cma: Fix erroneous validation of supported default GID type Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 02/22] IB/uverbs: Introduce and use helper functions to copy ah attributes Leon Romanovsky
     [not found]     ` <20170811105003.7661-3-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-11 12:15       ` Dennis Dalessandro
2017-08-11 10:49   ` [rdma-next 03/22] RDMA/mlx4: Don't use uninitialized variable Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 04/22] RDMA/mlx4: Fix create qp command alignment Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 05/22] RDMA/(core,ulp): Convert register/unregister event handler to be void Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 06/22] RDMA/core: Cleanup device capability enum Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 07/22] RDMA/core: Remove unimplemented node_types and node transport Leon Romanovsky
     [not found]     ` <20170811105003.7661-8-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-11 12:32       ` Dennis Dalessandro
2017-08-11 16:46       ` Hal Rosenstock
     [not found]         ` <36aea320-a018-040d-c44a-3a23d54771cd-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-08-11 18:13           ` Dennis Dalessandro
     [not found]             ` <72f3047f-8b29-435d-57bf-be0734606368-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-12  6:32               ` Leon Romanovsky
2017-08-11 18:13           ` Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 08/22] RDMA/core: Delete BUG() from unreachable flow Leon Romanovsky
     [not found]     ` <20170811105003.7661-9-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-13 10:21       ` Yuval Shaia
2017-08-13 10:29         ` Leon Romanovsky
     [not found]           ` <20170813102904.GV24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-13 10:51             ` Yuval Shaia
2017-08-13 11:00               ` Leon Romanovsky
     [not found]                 ` <20170813110017.GX24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-13 11:08                   ` Yuval Shaia
2017-08-11 10:49   ` [rdma-next 09/22] RDMA/core: Refactor get link layer wrapper Leon Romanovsky
     [not found]     ` <20170811105003.7661-10-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-13 10:13       ` Yuval Shaia
2017-08-11 10:49   ` [rdma-next 10/22] RDMA/mlx4: Remove gfp_mask argument from acquire_group call Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 11/22] RDMA/usnic: Fix remove address space warning Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 12/22] RDMA/mthca: Make explicit conversion to 64bit value Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 13/22] RDMA/hns: Remove empty functions Leon Romanovsky
     [not found]     ` <20170811105003.7661-14-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-11 12:26       ` Dennis Dalessandro
     [not found]         ` <fe444f34-ec1e-a5bb-34cb-0c34499d1e21-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-15  3:36           ` oulijun
2017-08-11 10:49   ` [rdma-next 14/22] IB/mlx4: Fix some spelling mistakes Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 15/22] IB/mlx5: " Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 16/22] IB/mlx5: Add necessary delay drop assignment Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 17/22] IB/mlx4: Fix RSS QP type in creation verb Leon Romanovsky
2017-08-11 10:49   ` [rdma-next 18/22] IB/mlx4: Fix struct mlx4_ib_create_wq alignment Leon Romanovsky
2017-08-11 10:50   ` [rdma-next 19/22] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct Leon Romanovsky
     [not found]     ` <20170811105003.7661-20-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-13  9:07       ` Yuval Shaia [this message]
2017-08-13  9:43         ` Leon Romanovsky
2017-08-11 10:50   ` [rdma-next 20/22] IB/mlx4: Check that reserved fields in mlx4_ib_create_qp_rss are zero Leon Romanovsky
     [not found]     ` <20170811105003.7661-21-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-13  9:17       ` Yuval Shaia
2017-08-13  9:58         ` Leon Romanovsky
2017-08-11 10:50   ` [rdma-next 21/22] IB/ipoib: Sync between remove_one to sysfs calls that use rtnl_lock Leon Romanovsky
2017-08-11 10:50   ` [rdma-next 22/22] IB/ipoib: Add get statistics support to SRIOV VF Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170813090745.GE3924@yuvallap \
    --to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox