From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [rdma-next 19/22] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct Date: Sun, 13 Aug 2017 12:07:46 +0300 Message-ID: <20170813090745.GE3924@yuvallap> References: <20170811105003.7661-1-leon@kernel.org> <20170811105003.7661-20-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170811105003.7661-20-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Guy Levi List-Id: linux-rdma@vger.kernel.org On Fri, Aug 11, 2017 at 01:50:00PM +0300, Leon Romanovsky wrote: > From: Guy Levi > > rss_key_len is not in use and need to be removed. > > Fixes: 3078f5f1bd8b ("IB/mlx4: Add support for RSS QP") > Signed-off-by: Guy Levi > Signed-off-by: Leon Romanovsky > --- > include/uapi/rdma/mlx4-abi.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/uapi/rdma/mlx4-abi.h b/include/uapi/rdma/mlx4-abi.h > index 0e10102861b5..c55f60e05f86 100644 > --- a/include/uapi/rdma/mlx4-abi.h > +++ b/include/uapi/rdma/mlx4-abi.h > @@ -98,8 +98,7 @@ struct mlx4_ib_create_srq_resp { > struct mlx4_ib_create_qp_rss { > __u64 rx_hash_fields_mask; > __u8 rx_hash_function; > - __u8 rx_key_len; > - __u8 reserved[6]; > + __u8 reserved[7]; Looks like this change is not explained in commit message. > __u8 rx_hash_key[40]; > __u32 comp_mask; > __u32 reserved1; > -- > 2.14.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html