From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [rdma-next 08/22] RDMA/core: Delete BUG() from unreachable flow Date: Sun, 13 Aug 2017 13:21:17 +0300 Message-ID: <20170813102115.GH3924@yuvallap> References: <20170811105003.7661-1-leon@kernel.org> <20170811105003.7661-9-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170811105003.7661-9-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On Fri, Aug 11, 2017 at 01:49:49PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Remove call to BUG() in case wrong node_type was provided. > This flow is unreachable, because node_types are supplied > from specific enum. > > Signed-off-by: Leon Romanovsky > Reviewed-by: Dennis Dalessandro > --- > drivers/infiniband/core/verbs.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c > index 21fef6b6d4f3..0d359a482b13 100644 > --- a/drivers/infiniband/core/verbs.c > +++ b/drivers/infiniband/core/verbs.c > @@ -180,17 +180,13 @@ EXPORT_SYMBOL(ib_rate_to_mbps); > __attribute_const__ enum rdma_transport_type > rdma_node_get_transport(enum rdma_node_type node_type) > { > - switch (node_type) { > - case RDMA_NODE_IB_CA: > + if (node_type == RDMA_NODE_IB_CA) > return RDMA_TRANSPORT_IB; > - case RDMA_NODE_RNIC: > + > + if (node_type == RDMA_NODE_RNIC) > return RDMA_TRANSPORT_IWARP; Looking at for-next, there is case for RDMA_NODE_USNIC. Which branch this patch is based on? > - case RDMA_NODE_USNIC_UDP: > - return RDMA_TRANSPORT_USNIC_UDP; > - default: > - BUG(); > - return 0; > - } > + > + return RDMA_TRANSPORT_USNIC_UDP; > } > EXPORT_SYMBOL(rdma_node_get_transport); > > -- > 2.14.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html