From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [rdma-next 08/22] RDMA/core: Delete BUG() from unreachable flow Date: Sun, 13 Aug 2017 13:29:04 +0300 Message-ID: <20170813102904.GV24282@mtr-leonro.local> References: <20170811105003.7661-1-leon@kernel.org> <20170811105003.7661-9-leon@kernel.org> <20170813102115.GH3924@yuvallap> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6tPipYVl+OcoAvSh" Return-path: Content-Disposition: inline In-Reply-To: <20170813102115.GH3924@yuvallap> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yuval Shaia Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org --6tPipYVl+OcoAvSh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Aug 13, 2017 at 01:21:17PM +0300, Yuval Shaia wrote: > On Fri, Aug 11, 2017 at 01:49:49PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Remove call to BUG() in case wrong node_type was provided. > > This flow is unreachable, because node_types are supplied > > from specific enum. > > > > Signed-off-by: Leon Romanovsky > > Reviewed-by: Dennis Dalessandro > > --- > > drivers/infiniband/core/verbs.c | 14 +++++--------- > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c > > index 21fef6b6d4f3..0d359a482b13 100644 > > --- a/drivers/infiniband/core/verbs.c > > +++ b/drivers/infiniband/core/verbs.c > > @@ -180,17 +180,13 @@ EXPORT_SYMBOL(ib_rate_to_mbps); > > __attribute_const__ enum rdma_transport_type > > rdma_node_get_transport(enum rdma_node_type node_type) > > { > > - switch (node_type) { > > - case RDMA_NODE_IB_CA: > > + if (node_type == RDMA_NODE_IB_CA) > > return RDMA_TRANSPORT_IB; > > - case RDMA_NODE_RNIC: > > + > > + if (node_type == RDMA_NODE_RNIC) > > return RDMA_TRANSPORT_IWARP; > > Looking at for-next, there is case for RDMA_NODE_USNIC. > Which branch this patch is based on? for-next, in case of RDMA_NODE_USNIC, we are using the RDMA_TRANSPORT_USNIC_UDP return type. > > > - case RDMA_NODE_USNIC_UDP: > > - return RDMA_TRANSPORT_USNIC_UDP; > > - default: > > - BUG(); > > - return 0; > > - } > > + > > + return RDMA_TRANSPORT_USNIC_UDP; > > } > > EXPORT_SYMBOL(rdma_node_get_transport); > > > > -- > > 2.14.0 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html --6tPipYVl+OcoAvSh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlmQKfAACgkQ5GN7iDZy WKcvOA//fDe6bn/SqLB2+R+1dCtZOZRbOSZpdSP7FF/z36iexsFp+CIdVbHtMpuT ZmGdE2MJXQo9wK6yKoh7Yxs1IyrhLixsf4lzcNeuN6+uBDbsFzDctyC2JJd0tDK/ fIs2QBLw53H4CS4x1o/tbbjY643ZeIp2vspinzrv4Cr8YnNN6r4I8h+TKVDKGOR2 683i3f93vCdL5iGO2DLVBjiUGNTv7U5p3hl6+WBSnYrMzy1sJ7WHWgZo5dng9pEx +UvhI4TKfKOl1QiP0RyeUjAmcIqLZwk87y4JsaFYl84XksQFVXWiS3RJY9hbqvt6 cx31z7GlrQY4xK111gLmrf/uhBEjHOj5ralPz5ZU4pZ9lERa3/d4mRcBttkC5c75 4ZobVRRbDBA/bDII1aPKBF6cgGsz3g/1I9RFrIqkq+dbZpGa8l3WhWV3Njlw1RLJ dSTgaKU7QThajCRXrPPq17xbCYMBholgt1OKYdwx5VJCPDQG0UrAUEorqbU8UnCv BPYNjw+o83ddY+s2XOO4gfQwTUpyXluVCIlqabBr86K+ftACpPRiTZVbcl2I0i3U 81X7A+cPtcgPYchsU09iZI2UOrWdNRVDFfybsSOdanPsKPqAtj/G4sZUgrcYwzvQ OoYTgbpT4J4MhCUAU88vOHmZLk4TLeZEUyY+OW3u/QUPd5tShak= =ZYMn -----END PGP SIGNATURE----- --6tPipYVl+OcoAvSh-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html