Re: [rdma-next 13/22] RDMA/hns: Remove empty functions

oulijun
2017-08-15T03:36:49Z

在 2017/8/11 20:26, Dennis Dalessandro 写道:
> On 8/11/2017 6:49 AM, Leon Romanovsky wrote:
>> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> The functions which are not implemented can be simply ignored
>> instead of defining empty function. This patch removes such functions
>> from hns driver.
>>
>> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> I thought I replied about this or a very similar patch, but can't find the link. Regardless, I think these sort of work-in-progress stubs are OK as incremental development, part of "showing your work" but I would have expected to see them implemented in the same series, or at least soon there-after. So the fact that these are still empty after this much time. I agree, get rid of them.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> .
>
Hi, Dennis Dalessandro

I have tested it on D05 board and the result is fail. The detail anlaysis refer to my reply email for

[rdma-next v1 13/22] patch.

Thanks

Lijun Ou