Re: [rdma-next 19/22] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct

Leon Romanovsky
2017-08-13T09:43:07Z

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

On Sun, Aug 13, 2017 at 12:07:46PM +0300, Yuval Shaia wrote:
> On Fri, Aug 11, 2017 at 01:50:00PM +0300, Leon Romanovsky wrote:
> > From: Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > rss_key_len is not in use and need to be removed.
> >
> > Fixes: 3078f5f1bd8b ("IB/mlx4: Add support for RSS QP")
> > Signed-off-by: Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > ---
> > include/uapi/rdma/mlx4-abi.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/include/uapi/rdma/mlx4-abi.h b/include/uapi/rdma/mlx4-abi.h
> > index 0e10102861b5..c55f60e05f86 100644
> > --- a/include/uapi/rdma/mlx4-abi.h
> > +++ b/include/uapi/rdma/mlx4-abi.h
> > @@ -98,8 +98,7 @@ struct mlx4_ib_create_srq_resp {
> > struct mlx4_ib_create_qp_rss {
> > __u64 rx_hash_fields_mask;
> > __u8 rx_hash_function;
> > - __u8 rx_key_len;
> > - __u8 reserved[6];
> > + __u8 reserved[7];
>
> Looks like this change is not explained in commit message.

It is exactly the change from commit message, we can't simply remove
fields from this structure because it should be properly aligned.

Thanks

>
> > __u8 rx_hash_key[40];
> > __u32 comp_mask;
> > __u32 reserved1;
> > --
> > 2.14.0
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]