From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [rdma-next 08/22] RDMA/core: Delete BUG() from unreachable flow Date: Sun, 13 Aug 2017 14:08:08 +0300 Message-ID: <20170813110807.GA5923@yuvallap> References: <20170811105003.7661-1-leon@kernel.org> <20170811105003.7661-9-leon@kernel.org> <20170813102115.GH3924@yuvallap> <20170813102904.GV24282@mtr-leonro.local> <20170813105139.GA5286@yuvallap> <20170813110017.GX24282@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170813110017.GX24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Sun, Aug 13, 2017 at 02:00:17PM +0300, Leon Romanovsky wrote: > On Sun, Aug 13, 2017 at 01:51:41PM +0300, Yuval Shaia wrote: > > On Sun, Aug 13, 2017 at 01:29:04PM +0300, Leon Romanovsky wrote: > > > On Sun, Aug 13, 2017 at 01:21:17PM +0300, Yuval Shaia wrote: > > > > On Fri, Aug 11, 2017 at 01:49:49PM +0300, Leon Romanovsky wrote: > > > > > From: Leon Romanovsky > > > > > > > > > > Remove call to BUG() in case wrong node_type was provided. > > > > > This flow is unreachable, because node_types are supplied > > > > > from specific enum. > > > > > > > > > > Signed-off-by: Leon Romanovsky > > > > > Reviewed-by: Dennis Dalessandro > > > > > --- > > > > > drivers/infiniband/core/verbs.c | 14 +++++--------- > > > > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > > > > > > > diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c > > > > > index 21fef6b6d4f3..0d359a482b13 100644 > > > > > --- a/drivers/infiniband/core/verbs.c > > > > > +++ b/drivers/infiniband/core/verbs.c > > > > > @@ -180,17 +180,13 @@ EXPORT_SYMBOL(ib_rate_to_mbps); > > > > > __attribute_const__ enum rdma_transport_type > > > > > rdma_node_get_transport(enum rdma_node_type node_type) > > > > > { > > > > > - switch (node_type) { > > > > > - case RDMA_NODE_IB_CA: > > > > > + if (node_type == RDMA_NODE_IB_CA) > > > > > return RDMA_TRANSPORT_IB; > > > > > - case RDMA_NODE_RNIC: > > > > > + > > > > > + if (node_type == RDMA_NODE_RNIC) > > > > > return RDMA_TRANSPORT_IWARP; > > > > > > > > Looking at for-next, there is case for RDMA_NODE_USNIC. > > > > Which branch this patch is based on? > > > > > > for-next, in case of RDMA_NODE_USNIC, we are using the > > > RDMA_TRANSPORT_USNIC_UDP return type. > > > > I see, but then i would expect to see these lines in the patch: > > - case RDMA_NODE_USNIC: > > - return RDMA_TRANSPORT_USNIC; > > Please see patch #7 from this series. Oops, Reviewed-by: Yuval Shaia > > Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html