Re: [rdma-next 13/22] RDMA/hns: Remove empty functions

Dennis Dalessandro
2017-08-11T12:26:38Z

On 8/11/2017 6:49 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> The functions which are not implemented can be simply ignored
> instead of defining empty function. This patch removes such functions
> from hns driver.
>
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

I thought I replied about this or a very similar patch, but can't find
the link. Regardless, I think these sort of work-in-progress stubs are
OK as incremental development, part of "showing your work" but I would
have expected to see them implemented in the same series, or at least
soon there-after. So the fact that these are still empty after this much
time. I agree, get rid of them.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>