linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [rdma-next v2 19/23] IB/mlx4: Check that reserved fields in mlx4_ib_create_qp_rss are zero
Date: Tue, 15 Aug 2017 11:54:48 +0300	[thread overview]
Message-ID: <20170815085452.3546-20-leon@kernel.org> (raw)
In-Reply-To: <20170815085452.3546-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

From: Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

According to mlx4 convention, need to fail the command due to a non-zero
value in the user data which is expected to be zero.

Fixes: 3078f5f1bd8b ("IB/mlx4: Add support for RSS QP")
Signed-off-by: Guy Levi <guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 drivers/infiniband/hw/mlx4/qp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c
index 44d2d0a2d5e0..2874d8790570 100644
--- a/drivers/infiniband/hw/mlx4/qp.c
+++ b/drivers/infiniband/hw/mlx4/qp.c
@@ -813,6 +813,9 @@ static struct ib_qp *_mlx4_ib_create_qp_rss(struct ib_pd *pd,
 		return ERR_PTR(-EFAULT);
 	}
 
+	if (memchr_inv(ucmd.reserved, 0, sizeof(ucmd.reserved)))
+		return ERR_PTR(-EOPNOTSUPP);
+
 	if (ucmd.comp_mask || ucmd.reserved1)
 		return ERR_PTR(-EOPNOTSUPP);
 
-- 
2.14.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-08-15  8:54 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15  8:54 [pull request][rdma-next v2 00/23] RDMA core, drivers and IPoIB fixes Leon Romanovsky
     [not found] ` <20170815085452.3546-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-15  8:54   ` [rdma-next v2 01/23] IB/cma: Fix erroneous validation of supported default GID type Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 02/23] IB/uverbs: Introduce and use helper functions to copy ah attributes Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 03/23] RDMA/mlx4: Don't use uninitialized variable Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 04/23] RDMA/mlx4: Fix create qp command alignment Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 05/23] RDMA/(core,ulp): Convert register/unregister event handler to be void Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 06/23] RDMA/core: Cleanup device capability enum Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 07/23] RDMA/core: Remove unimplemented node_types and node transport Leon Romanovsky
     [not found]     ` <20170815085452.3546-8-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-15 18:25       ` Suri Shelvapille
     [not found]         ` <SN1PR0301MB2127376FC9B3D170C878A47BDE8D0-VLIetriUNob/KlJXleiaIJwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-08-16  5:37           ` Leon Romanovsky
     [not found]             ` <20170816053744.GD24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-16 14:30               ` Suri Shelvapille
     [not found]                 ` <SN1PR0301MB21274177B67EE02B96F14424DE820-VLIetriUNob/KlJXleiaIJwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-08-16 16:05                   ` Devesh Sharma
2017-08-16 16:21                   ` Leon Romanovsky
     [not found]                     ` <20170816162103.GT24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-16 18:53                       ` Leon Romanovsky
     [not found]                 ` <CANjDDBh=3=5pwYO0_hcZDYVe2H98NMdTT_KrHz7j2Hm74ftDjw@mail.gmail.com>
     [not found]                   ` <CANjDDBh=3=5pwYO0_hcZDYVe2H98NMdTT_KrHz7j2Hm74ftDjw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-16 16:26                     ` Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 08/23] RDMA/core: Delete BUG() from unreachable flow Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 09/23] RDMA/core: Refactor get link layer wrapper Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 10/23] RDMA/mlx4: Remove gfp_mask argument from acquire_group call Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 11/23] RDMA/usnic: Fix remove address space warning Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 12/23] RDMA/mthca: Make explicit conversion to 64bit value Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 13/23] IB/mlx4: Fix some spelling mistakes Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 14/23] IB/mlx5: " Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 15/23] IB/mlx5: Add necessary delay drop assignment Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 16/23] IB/mlx4: Fix RSS QP type in creation verb Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 17/23] IB/mlx4: Fix struct mlx4_ib_create_wq alignment Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 18/23] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct Leon Romanovsky
     [not found]     ` <20170815085452.3546-19-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-22 20:09       ` Doug Ledford
     [not found]         ` <1503432590.78641.10.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-23  4:43           ` Leon Romanovsky
     [not found]             ` <20170823044354.GJ1724-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-24  9:22               ` Leon Romanovsky
     [not found]                 ` <20170824092228.GF1724-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-24 19:40                   ` Doug Ledford
2017-08-15  8:54   ` Leon Romanovsky [this message]
2017-08-15  8:54   ` [rdma-next v2 20/23] IB/ipoib: Sync between remove_one to sysfs calls that use rtnl_lock Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 21/23] IB/ipoib: Add get statistics support to SRIOV VF Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 22/23] IB/rxe: Make rxe_counter_name static Leon Romanovsky
2017-08-15  8:54   ` [rdma-next v2 23/23] RDMA/mlx5: Limit scope of get vector affinity local function Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815085452.3546-20-leon@kernel.org \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=guyle-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).