From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2 2/2] rdma: Autoload netlink client modules
Date: Tue, 15 Aug 2017 18:58:43 +0300 [thread overview]
Message-ID: <20170815155843.GT24282@mtr-leonro.local> (raw)
In-Reply-To: <20170815153523.GA14623-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On Tue, Aug 15, 2017 at 09:35:23AM -0600, Jason Gunthorpe wrote:
> On Tue, Aug 15, 2017 at 12:56:51PM +0300, Leon Romanovsky wrote:
>
> > Can it be something like that (untested)?
> > #define MODULE_ALIAS_RDMA_NETLINK(_index)
>
> No, MODULE_ALIAS does something like
>
> static const char __UNIQUE_ID(name)[]
> __used __attribute__((section(".modinfo"), unused, aligned(1))) = __stringify(tag) "=" info;
>
> So it must accept a string produced by the pre-processor, not by code.
But the netlink indexes were defined as anonymous enum, can we safely
convert them to be defines?
>
> Jason
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-15 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 20:57 [PATCH v2 0/2] Autoloading for RDMA netlink modules Jason Gunthorpe
[not found] ` <1502744259-16966-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-14 20:57 ` [PATCH v2 1/2] rdma: Allow demand loading of NETLINK_RDMA Jason Gunthorpe
[not found] ` <1502744259-16966-2-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-15 9:20 ` Leon Romanovsky
2017-08-14 20:57 ` [PATCH v2 2/2] rdma: Autoload netlink client modules Jason Gunthorpe
[not found] ` <1502744259-16966-3-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-15 9:56 ` Leon Romanovsky
[not found] ` <20170815095651.GQ24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-15 15:35 ` Jason Gunthorpe
[not found] ` <20170815153523.GA14623-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-15 15:58 ` Leon Romanovsky [this message]
[not found] ` <20170815155843.GT24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-15 16:57 ` Jason Gunthorpe
[not found] ` <20170815165737.GB15171-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-15 17:40 ` Leon Romanovsky
[not found] ` <20170815174058.GW24282-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-16 15:36 ` Jason Gunthorpe
[not found] ` <20170816153620.GA22584-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-16 15:59 ` Leon Romanovsky
2017-08-22 21:07 ` [PATCH v2 0/2] Autoloading for RDMA netlink modules Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815155843.GT24282@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox