From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Cc: mlindner-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org,
mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Stephen Hemminger
<sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
Subject: Re: [PATCH net-next 4/4] mlx4: sizeof style usage
Date: Tue, 15 Aug 2017 21:13:24 +0300 [thread overview]
Message-ID: <20170815181324.GA24282@mtr-leonro.local> (raw)
In-Reply-To: <20170815172919.26153-5-sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]
On Tue, Aug 15, 2017 at 10:29:19AM -0700, Stephen Hemminger wrote:
> The kernel coding style is to treat sizeof as a function
> (ie. with parenthesis) not as an operator.
>
> Also use kcalloc and kmalloc_array
>
> Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
> ---
> drivers/net/ethernet/mellanox/mlx4/alloc.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/cmd.c | 4 ++--
> drivers/net/ethernet/mellanox/mlx4/en_resources.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/eq.c | 20 +++++++++---------
> drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/icm.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/icm.h | 4 ++--
> drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/main.c | 12 +++++------
> drivers/net/ethernet/mellanox/mlx4/mcg.c | 12 +++++------
> drivers/net/ethernet/mellanox/mlx4/mr.c | 10 ++++-----
> drivers/net/ethernet/mellanox/mlx4/qp.c | 12 +++++------
> .../net/ethernet/mellanox/mlx4/resource_tracker.c | 24 +++++++++++-----------
> 15 files changed, 56 insertions(+), 56 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-15 18:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 17:29 [PATCH net-next 0/4] various sizeof cleanups Stephen Hemminger
2017-08-15 17:29 ` [PATCH net-next 1/4] tun/tap: use paren's with sizeof Stephen Hemminger
2017-08-15 17:29 ` [PATCH net-next 2/4] virtio: put paren around sizeof Stephen Hemminger
2017-08-15 17:29 ` [PATCH net-next 3/4] skge: add paren around sizeof arg Stephen Hemminger
2017-08-15 17:29 ` [PATCH net-next 4/4] mlx4: sizeof style usage Stephen Hemminger
[not found] ` <20170815172919.26153-5-sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
2017-08-15 18:13 ` Leon Romanovsky [this message]
2017-08-20 10:27 ` Tariq Toukan
2017-08-20 18:00 ` Stephen Hemminger
[not found] ` <DM2PR21MB0074E2B2C697B1300B77EFEACC860-B2pw06WL+/BdZnmuHZ3GOs1VXTxX1y3OvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-08-21 10:53 ` Tariq Toukan
2017-08-15 19:47 ` [PATCH net-next 0/4] various sizeof cleanups Michael S. Tsirkin
[not found] ` <20170815172919.26153-1-sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
2017-08-16 18:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815181324.GA24282@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mlindner-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
--cc=sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org \
--cc=virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox