From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [PATCH rdma-next v3-v6] Add OPA extended LID support Date: Wed, 16 Aug 2017 09:09:06 +0300 Message-ID: <20170816060906.GF24282@mtr-leonro.local> References: <1502734663-44224-1-git-send-email-don.hiatt@intel.com> <50ff7793-413a-09a6-1805-ca0bce0452a2@intel.com> <8d3d0a5a-df5e-b023-ec7c-f83e47a22f00@intel.com> <82b0f16b-86e5-0b24-c638-d8a606047f87@intel.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Qf878oECjVTnCF6M" Return-path: Content-Disposition: inline In-Reply-To: <82b0f16b-86e5-0b24-c638-d8a606047f87-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Don Hiatt Cc: linux-rdma List-Id: linux-rdma@vger.kernel.org --Qf878oECjVTnCF6M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 15, 2017 at 03:13:35PM -0700, Don Hiatt wrote: > > > On 8/15/2017 1:40 PM, Don Hiatt wrote: > > > > > > On 8/14/2017 1:12 PM, Don Hiatt wrote: > > > On 8/14/2017 11:36 AM, Don Hiatt wrote: > > > > > > > > > > > > On 8/14/2017 11:17 AM, Don Hiatt wrote: > > > > > This patch series primarily increases sizes of variables that hold > > > > > lid values from 16 to 32 bits. Additionally, it adds a check in > > > > > the IB mad stack to verify a properly formatted MAD when OPA > > > > > extended LIDs are used. > > > > > > > > > > Signed-off-by: Don Hiatt > > > > > Reviewed-by: Dennis Dalessandro > > > > > --- > > > > > > > > > > This is an incremental patch to move from v3 of the 'Add OPA > > > > > extended LID support' to v6 of the series. > > > > > Changes from v5: > > > > > --------------- > > > > > * Fixed typo in WARN_ON_ONCE usage in helper functions. > > > > > * Actually return be16 in ib_lid_be16() helper function. > > > > > > > > Sorry, this was meant to go to my email as a test, not to the > > > > list. My tests are still running so please > > > > hold off on this until I confirm. > > > > > > > All test completed fine. I think we're good to go. > > > > > > Leon, if I missed anything else please let me know. > > > > > > Thanks, > > > > > > don > > > > > I did not get this email respond but saw it on the mailing list so > > pasted it in to respond) > > > > >Yeah, you should fix the function below too. > > >The whole extended LID series did enormous mess with all these > > lid/slid/dlid. > > > > > > 88 static inline bool opa_is_extended_lid(u32 dlid, u32 slid) > > > 89 { > > > 90 if ((be32_to_cpu(dlid) >= > > > 91 be16_to_cpu(IB_MULTICAST_LID_BASE)) || > > > 92 (be32_to_cpu(slid) >= > > > 93 be16_to_cpu(IB_MULTICAST_LID_BASE))) > > > 94 return true; > > > 95 else > > > 96 return false; > > > 97 } > > > > > >It will help a lot, if you break this patch to small steps: > > >1. Fix existing annotation errors. > > >2. Change (rename) the ib_lid/ib_slid functions. > > >3. Add WARN_ON. > > > > > >Right now, we have potential breakage of compatibility between > > >big-endian vs. little-endian systems. > > > > > >Please run smatch and sparse checkers before LID patches and after to > > >know what else you should fix. > > > > > > Thanks > > > > This patch series sat on the mailing list for over two months since the > > your last > > request. It then got merged in and an incremental patch was asked for. > > > > I've been trying to address your concerns but since this patch is going > > in as an > > incremental patch I do not see how breaking it up as requested is > > required. > > > > If Doug would like to pull the entire series then I'll break the > > patchfor es up. > > > > As of now, with this patch the endian-ness issues have been resolved, or > > are you > > saying they are not? > > > > > I ran sparse/smatch and the endian issues are fixed. The only smatch > warnings in this > patch are for OPA record types. Once this incremental patch is accepted I'll > follow > up to specifically address the OPA record type warnings. Please don't wait and address it now. Thanks. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --Qf878oECjVTnCF6M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlmT4YIACgkQ5GN7iDZy WKfR+g//YFvHI2jzuGXizDb1tB0ATU73R4N08lzZWFNm/BLFAwIrpVfav7XrNRnZ 1bo48/l2HLBRSsGzc2MqL9S1yr2IeqNa1fCUmJF3lmkFyCuFVb9FyUFQwY80ENhY b3FtKW79CzD/0q7b4vx2s/dm+AG8mpPxNGC3VyaFWcVgW9njZsy9BOYjJnJWjJSE xGFeOl9cM9StfuwS8oHRtxsnsAFQR9dVGYS/X1aw6HQg1SpKo8ZKWLDlMkVWOlWy GJ+WxzKX4DoRMECAcLOzuIXQsdgDxNqELUma1bzl/YMjsV0CXie2ug0nNObE59Fq mzXEol8VGRDI11SRp8qsJSSLZ3bhIENORI+sKqNf4s0PeB37nb2GshHDbuWR+98O uW0ERo2DiWnZT5QZNWg2dY5ssOg5EQPVhSTXsgF3uBEjaIZAClzGUK5Y4UaB/tRR Zs6h3PiVw9m5cELrv4zDRkM91kH0S8HeQIt7AClNSxOmjaYFQNrbEs6v0VyJ5RrO Qlb8WsZwrqh3fVKSVZqq4eVZ0/jaN3H/YtiVsYgPUfbAjYlsV2jDAKjrLST2DeVj a9uedPCwCUDgJblTyJIS2m33LdSwMWnvDqALN/HudzZujOvBa94iOh6kgdmfDRGS qbjy/emEluwN895pnPTOJ+KL1hd8ZyuyD3t5oHWzs5mTWWMVdpo= =4eH0 -----END PGP SIGNATURE----- --Qf878oECjVTnCF6M-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html