public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Li Dongyang <dongyang.li-FCV4sgi5zeUQrrorzV6ljw@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/2] IB/mlx5: use kvmalloc_array for mlx5_ib_wq
Date: Wed, 16 Aug 2017 16:57:57 +0300	[thread overview]
Message-ID: <20170816135757.GO24282@mtr-leonro.local> (raw)
In-Reply-To: <20170816133123.20497-1-dongyang.li-FCV4sgi5zeUQrrorzV6ljw@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

On Wed, Aug 16, 2017 at 11:31:22PM +1000, Li Dongyang wrote:
> We observed multiple times on our Lustre OSS servers that when
> the system memory is fragmented, kmalloc() in create_kernel_qp()
> could fail order 4/5 allocations while we still have many free pages.
>
> Switch to kvmalloc_array() to allow the operation to contine.
>
> Signed-off-by: Li Dongyang <dongyang.li-FCV4sgi5zeUQrrorzV6ljw@public.gmane.org>
> ---
>  drivers/infiniband/hw/mlx5/qp.c  | 35 ++++++++++++++++++++---------------
>  drivers/infiniband/hw/mlx5/srq.c |  4 ++--
>  2 files changed, 22 insertions(+), 17 deletions(-)
>

Thanks,
Acked-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-08-16 13:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16 13:31 [PATCH v2 1/2] IB/mlx5: use kvmalloc_array for mlx5_ib_wq Li Dongyang
     [not found] ` <20170816133123.20497-1-dongyang.li-FCV4sgi5zeUQrrorzV6ljw@public.gmane.org>
2017-08-16 13:31   ` [PATCH v2 2/2] IB/mlx4: use kvmalloc_array to allocate wrid Li Dongyang
     [not found]     ` <20170816133123.20497-2-dongyang.li-FCV4sgi5zeUQrrorzV6ljw@public.gmane.org>
2017-08-16 14:01       ` Leon Romanovsky
2017-08-22 20:49       ` Doug Ledford
2017-08-16 13:57   ` Leon Romanovsky [this message]
2017-08-22 20:48   ` [PATCH v2 1/2] IB/mlx5: use kvmalloc_array for mlx5_ib_wq Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170816135757.GO24282@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dongyang.li-FCV4sgi5zeUQrrorzV6ljw@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox