Re: [rdma-next v2 07/23] RDMA/core: Remove unimplemented node_types and node transport

Devesh Sharma
2017-08-16T16:05:08Z

Hi Leon,

We probably should be okay to retain SWITCH and ROUTER devices, lets
say if someone wants to port entire linux kernel IB stack on a
IB-switch or Router. Probably portability was the motivation to add
these since the birth of kernel IB stack.

On Wed, Aug 16, 2017 at 8:00 PM, Suri Shelvapille
<suri-lFb5ksp6isWhEniVeURVKkEOCMrvLtNR@public.gmane.org> wrote:
> Leon:
> Our Drivers are not in Kernel (being a small company we don't have resources to make it in-kernel). When I and Hal worked on adding the switch capability into the kernel, we thought it would be useful for the community (as there was interest in a few others besides us). Philosophically, since SWITCH and ROUTER definitions are part of the IB spec, don't you think having these definitions makes the kernel close to spec and hence useful? I know these definitions can be easily added into our drivers.
> Just treat this as a request, if it is not an onus to the community, please keep the SWITCH and ROUTER (only) definitions. If you have strong reasons I have no objections to your patches.
>
> Thanks,
> Suri
>
> -----Original Message-----
> From: Leon Romanovsky [mailto:leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org]
> Sent: Wednesday, August 16, 2017 1:38 AM
> To: Suri Shelvapille <suri-lFb5ksp6isWhEniVeURVKkEOCMrvLtNR@public.gmane.org>
> Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: Re: [rdma-next v2 07/23] RDMA/core: Remove unimplemented node_types and node transport
>
> On Tue, Aug 15, 2017 at 06:25:54PM +0000, Suri Shelvapille wrote:
>> Leon:
>>
>> We do have IB_SWITCH and IB_ROUTER functionality and we do use the SWITCH capability provided by the "core" in our product. The "core" has a wrapper function which Identifies the device as a switch to direct smp packets. I am glad that has not been removed. And I hope it won't be removed as it would be a burden to us. Although we prefer to have the IB_SWITCH/IB_ROUTER definitions in the core as well, it is not a big deal to move these definitions inside our driver.
>>
>
> Can you please point me to IN-KERNEL hardware/driver where these values are being set? Because I didn't find any.
>
> Thanks
>
> This correspondence, and any attachments or files transmitted with this correspondence, contains information which may be confidential and privileged and is intended solely for the use of the addressee. Unless you are the addressee or are authorized to receive messages for the addressee, you may not use, copy, disseminate, or disclose this correspondence or any information contained in this correspondence to any third party. If you have received this correspondence in error, please notify the sender immediately and delete this correspondence and any attachments or files transmitted with this correspondence from your system, and destroy any and all copies thereof, electronic or otherwise. Your cooperation and understanding are greatly appreciated.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html