linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [rdma-next v3 07/24] RDMA/core: Delete BUG() from unreachable flow
Date: Thu, 17 Aug 2017 15:50:38 +0300	[thread overview]
Message-ID: <20170817125055.31424-8-leon@kernel.org> (raw)
In-Reply-To: <20170817125055.31424-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Remove call to BUG() in case wrong node_type was provided.
This flow is unreachable, because node_types are supplied
from specific enum.

Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/core/verbs.c | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 3d1de62de839..aee23deba074 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -180,21 +180,15 @@ EXPORT_SYMBOL(ib_rate_to_mbps);
 __attribute_const__ enum rdma_transport_type
 rdma_node_get_transport(enum rdma_node_type node_type)
 {
-	switch (node_type) {
-	case RDMA_NODE_IB_CA:
-	case RDMA_NODE_IB_SWITCH:
-	case RDMA_NODE_IB_ROUTER:
-		return RDMA_TRANSPORT_IB;
-	case RDMA_NODE_RNIC:
-		return RDMA_TRANSPORT_IWARP;
-	case RDMA_NODE_USNIC:
+
+	if (node_type == RDMA_NODE_USNIC)
 		return RDMA_TRANSPORT_USNIC;
-	case RDMA_NODE_USNIC_UDP:
+	if (node_type == RDMA_NODE_USNIC_UDP)
 		return RDMA_TRANSPORT_USNIC_UDP;
-	default:
-		BUG();
-		return 0;
-	}
+	if (node_type == RDMA_NODE_RNIC)
+		return RDMA_TRANSPORT_IWARP;
+
+	return RDMA_TRANSPORT_IB;
 }
 EXPORT_SYMBOL(rdma_node_get_transport);
 
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-08-17 12:50 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 12:50 [pull request][rdma-next v3 00/24] RDMA core, drivers and IPoIB fixes Leon Romanovsky
     [not found] ` <20170817125055.31424-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-17 12:50   ` [rdma-next v3 01/24] IB/cma: Fix erroneous validation of supported default GID type Leon Romanovsky
     [not found]     ` <20170817125055.31424-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-23  8:50       ` Selvin Xavier
2017-08-17 12:50   ` [rdma-next v3 02/24] IB/uverbs: Introduce and use helper functions to copy ah attributes Leon Romanovsky
     [not found]     ` <20170817125055.31424-3-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-24 20:40       ` Doug Ledford
     [not found]         ` <1503607242.78641.48.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-27 11:10           ` Leon Romanovsky
     [not found]             ` <20170827111059.GQ1724-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-28 15:15               ` Doug Ledford
     [not found]                 ` <1503933314.78641.82.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-28 15:55                   ` Leon Romanovsky
     [not found]                     ` <20170828155552.GB23726-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-28 16:32                       ` Doug Ledford
     [not found]                         ` <1503937924.78641.94.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-28 17:20                           ` Leon Romanovsky
     [not found]                             ` <20170828172026.GE23726-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-28 17:24                               ` Leon Romanovsky
2017-08-28 18:09                           ` Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 03/24] RDMA/mlx4: Don't use uninitialized variable Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 04/24] RDMA/mlx4: Fix create qp command alignment Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 05/24] RDMA/(core,ulp): Convert register/unregister event handler to be void Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 06/24] RDMA/core: Cleanup device capability enum Leon Romanovsky
2017-08-17 12:50   ` Leon Romanovsky [this message]
2017-08-17 12:50   ` [rdma-next v3 08/24] RDMA/core: Refactor get link layer wrapper Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 09/24] RDMA/mlx4: Remove gfp_mask argument from acquire_group call Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 10/24] RDMA/usnic: Fix remove address space warning Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 11/24] RDMA/mthca: Make explicit conversion to 64bit value Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 12/24] IB/mlx4: Fix some spelling mistakes Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 13/24] IB/mlx5: " Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 14/24] IB/mlx5: Add necessary delay drop assignment Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 15/24] IB/mlx4: Fix RSS QP type in creation verb Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 16/24] IB/mlx4: Fix struct mlx4_ib_create_wq alignment Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 17/24] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct Leon Romanovsky
     [not found]     ` <20170817125055.31424-18-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-24 20:41       ` Doug Ledford
2017-08-17 12:50   ` [rdma-next v3 18/24] IB/mlx4: Check that reserved fields in mlx4_ib_create_qp_rss are zero Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 19/24] IB/ipoib: Sync between remove_one to sysfs calls that use rtnl_lock Leon Romanovsky
     [not found]     ` <20170817125055.31424-20-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-24 20:49       ` Doug Ledford
2017-08-17 12:50   ` [rdma-next v3 20/24] IB/ipoib: Add get statistics support to SRIOV VF Leon Romanovsky
     [not found]     ` <20170817125055.31424-21-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-08-24 20:44       ` Doug Ledford
     [not found]         ` <1503607480.78641.51.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-27 11:17           ` Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 21/24] IB/rxe: Make rxe_counter_name static Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 22/24] RDMA/mlx5: Limit scope of get vector affinity local function Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 23/24] RDMA/mlx4: Properly annotate link layer variable Leon Romanovsky
2017-08-17 12:50   ` [rdma-next v3 24/24] RDMA/nes: Remove zeroed parameter from port query callback Leon Romanovsky
2017-08-24 20:52   ` [pull request][rdma-next v3 00/24] RDMA core, drivers and IPoIB fixes Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170817125055.31424-8-leon@kernel.org \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).