Re: [PATCH rdma-core] mlx5: Return pointer to CQ doorbell

Jason Gunthorpe
2017-08-23T16:52:21Z

On Wed, Aug 23, 2017 at 07:45:55PM +0300, Leon Romanovsky wrote:

> > Provide two implementations of mlx5dv_init_obj, one that has the
> > historical behaviour that has existed until now of returning the
> > void **uar and a new version that returns the 'void *' version
> > renamed to arb_db.
>
> arb_db -> arm_db

Oops, I fixed that, thanks.

> Strange, in github it has 7 digits (the same was with rsocket fixes)
> Fixes: c6e3439 ("mlx5: Return pointer to CQ doorbell")

Yeah, side effect of github rendering it into a web link, I think.

> The overall looks good, but I need to run checks with before
> applying it.

Sure, I didn't test it obviously, but the readelf is what I expect:

101: 000000000000e4d0 55 FUNC GLOBAL DEFAULT 13 mlx5dv_init_obj@MLX5_1.0
168: 000000000000e4d0 55 FUNC LOCAL DEFAULT 13 __mlx5dv_init_obj_1_0
102: 000000000000e300 451 FUNC GLOBAL DEFAULT 13 mlx5dv_init_obj@@MLX5_1.2
169: 000000000000e300 451 FUNC LOCAL DEFAULT 13 __mlx5dv_init_obj_1_2