From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [rdma-next v2 18/23] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct Date: Wed, 23 Aug 2017 07:43:54 +0300 Message-ID: <20170823044354.GJ1724@mtr-leonro.local> References: <20170815085452.3546-1-leon@kernel.org> <20170815085452.3546-19-leon@kernel.org> <1503432590.78641.10.camel@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BqNvIJgrK1/MQy2W" Return-path: Content-Disposition: inline In-Reply-To: <1503432590.78641.10.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Guy Levi List-Id: linux-rdma@vger.kernel.org --BqNvIJgrK1/MQy2W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 22, 2017 at 04:09:50PM -0400, Doug Ledford wrote: > On Tue, 2017-08-15 at 11:54 +0300, Leon Romanovsky wrote: > > From: Guy Levi > > > > rss_key_len is not in use and need to be removed. > > > > Fixes: 3078f5f1bd8b ("IB/mlx4: Add support for RSS QP") > > Signed-off-by: Guy Levi > > Signed-off-by: Leon Romanovsky > > --- > > include/uapi/rdma/mlx4-abi.h | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/include/uapi/rdma/mlx4-abi.h b/include/uapi/rdma/mlx4- > > abi.h > > index 0e10102861b5..c55f60e05f86 100644 > > --- a/include/uapi/rdma/mlx4-abi.h > > +++ b/include/uapi/rdma/mlx4-abi.h > > @@ -98,8 +98,7 @@ struct mlx4_ib_create_srq_resp { > > struct mlx4_ib_create_qp_rss { > > __u64 rx_hash_fields_mask; > > __u8 rx_hash_function; > > - __u8 rx_key_len; > > - __u8 reserved[6]; > > + __u8 reserved[7]; > > I believe Yuval's point, which has not been fixed, was not that you > could remove the variable without increasing the reserved size. That > makes sense. He was referring to the fact that you reference > rss_key_len in the commit message, but what you removed was rx_key_len > instead. Ahh, I didn't understand it from his comment back then. How do you want me to proceed here? Do you want me to resend all patches? Do you want me to resend this patch only? Do you prefer to fix it by yourself? It looks like we can declare working with pull-requests in RDMA as a failed experiment. > > > __u8 rx_hash_key[40]; > > __u32 comp_mask; > > __u32 reserved1; > -- > Doug Ledford > GPG KeyID: B826A3330E572FDD > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD > --BqNvIJgrK1/MQy2W Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlmdCAoACgkQ5GN7iDZy WKchihAAn6ygwmkZ/j5Ae322sGmqATSOjzAGc+h1Jhy0H2IflQICy7xv6qX3NmC6 Vyf5sJoJafSc4l/dD7NL2FYzxaUqWooaVcI9c/YSAWHkCOlQ/HBa3OVQx4RdAJDK sHrA5Kt08/4DS3Udsx4DSqadYwSHPUhBPu4HX2Kt3GReqX4WeTelqK7QwXi45qNa zLrcHbODgY9OIlbHtHGbyXKe9JV1sZBb8QE+wvj2xi6lDH0qY7GANuPUtmt3qB5p Lrq63G2OCYJ4yvbTnVyKgQUX3sgpr0YhC4R4E5QEDDibLJBMaPdAAKCht2LBMJlM D2zuZnY51TbQd0CSjwjBlWb2V16uKxbbrR+oM5qHvTyoo6owLcWMoRICH0LzW+Dz FAENVhoDmWcqvm4mR4La09bSjQD+LlKdaEZDpMst1ijJ0k9EOFceYbeuwLpb425N DNFMdrS6XMCi6hLCKf19eKuGs41Q7FApIJiWGUohfaY+g/NhE3/jdPuNjfpgJHrF jOFAwRKWpRYrRtF2Qj3y3ZtUmw8f9fxCHLM08poxuUpCODhjvllJWv2USTnMU/yU NAP+6XAYFGsnkBAIbUrVBW9MXsomT8EZGjVThOInCj3xd/Iwh57k/CY/+D2nAgrI wR1FMCN+y98XEcuL+ZphayXmPdXp1KVcptfW7YygywGDr1TcNlY= =Cs3W -----END PGP SIGNATURE----- --BqNvIJgrK1/MQy2W-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html