Re: [PATCH for-4.14] IB: Avoid ib_modify_port() failure for RoCE devices

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

On Wed, Aug 23, 2017 at 01:08:07AM -0700, Selvin Xavier wrote:
> IB CM calls ib_modify_port() irrespective of link layer. If the
> failure is returned, the mad agent gets unregistered for those
> devices. Recently, modify_port() hook was removed from some of the
> low level drivers as it was always returning success. This breaks
> rdma connection establishment over those devices.
> For ethernet devices, Qkey violation and port capabilities are not
> applicable. So returning success for RoCE when modify_port hook is
> is not implemented.
>
> Cc: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Selvin Xavier <selvin.xavier-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> ---
>  drivers/infiniband/core/device.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]