From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Subject: Re: [rdma-next v2 18/23] IB/mlx4: Remove redundant attribute in mlx4_ib_create_qp_rss struct Date: Thu, 24 Aug 2017 12:22:28 +0300 Message-ID: <20170824092228.GF1724@mtr-leonro.local> References: <20170815085452.3546-1-leon@kernel.org> <20170815085452.3546-19-leon@kernel.org> <1503432590.78641.10.camel@redhat.com> <20170823044354.GJ1724@mtr-leonro.local> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NSyv3PxMn0vTUI/G" Return-path: Content-Disposition: inline In-Reply-To: <20170823044354.GJ1724-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Guy Levi List-Id: linux-rdma@vger.kernel.org --NSyv3PxMn0vTUI/G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 23, 2017 at 07:43:54AM +0300, Leon Romanovsky wrote: > On Tue, Aug 22, 2017 at 04:09:50PM -0400, Doug Ledford wrote: > > On Tue, 2017-08-15 at 11:54 +0300, Leon Romanovsky wrote: > > > From: Guy Levi > > > > > > rss_key_len is not in use and need to be removed. > > > > > > Fixes: 3078f5f1bd8b ("IB/mlx4: Add support for RSS QP") > > > Signed-off-by: Guy Levi > > > Signed-off-by: Leon Romanovsky > > > --- > > > include/uapi/rdma/mlx4-abi.h | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/include/uapi/rdma/mlx4-abi.h b/include/uapi/rdma/mlx4- > > > abi.h > > > index 0e10102861b5..c55f60e05f86 100644 > > > --- a/include/uapi/rdma/mlx4-abi.h > > > +++ b/include/uapi/rdma/mlx4-abi.h > > > @@ -98,8 +98,7 @@ struct mlx4_ib_create_srq_resp { > > > struct mlx4_ib_create_qp_rss { > > > __u64 rx_hash_fields_mask; > > > __u8 rx_hash_function; > > > - __u8 rx_key_len; > > > - __u8 reserved[6]; > > > + __u8 reserved[7]; > > > > I believe Yuval's point, which has not been fixed, was not that you > > could remove the variable without increasing the reserved size. That > > makes sense. He was referring to the fact that you reference > > rss_key_len in the commit message, but what you removed was rx_key_len > > instead. > > Ahh, I didn't understand it from his comment back then. > > How do you want me to proceed here? Do you want me to resend all patches? > Do you want me to resend this patch only? Do you prefer to fix it by yourself? Doug? > > It looks like we can declare working with pull-requests in RDMA as a failed > experiment. > > > > > > __u8 rx_hash_key[40]; > > > __u32 comp_mask; > > > __u32 reserved1; > > -- > > Doug Ledford > > GPG KeyID: B826A3330E572FDD > > Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD > > --NSyv3PxMn0vTUI/G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlmemtQACgkQ5GN7iDZy WKeH2g/+NSRxetoNbJp9r9asT+e0gKLjPvTk/h5oExlgDzT+xbYosfeIpmMlry/l jOMNEriVXZroSaEBq1KAtPZQ3YxghWQ/iAcjrIMVf6SHVe4ffFdUOSYDohRJxwdo A78xeLvaZAjYCJO2YtEPWb7nGlIw33yYLaOSzy48Baa3a/mrbtzUlaVDtP0wmXk9 IIxKgWzDFFGQSwdU6+lm+gjMjnKorZ4RyYHuoYWGcwAP5dJLmEIIaR2JjaOIRe4M dtcd7xEGxLKILF4FrCRbr8Q2OOx+eD/nKT9BogijSMIQzpL3uu8q5JvMnpcZlOmr zgDxMS8jPbuB/8Qn1cToHxjwASdxlS0F4miVCZiTU9GJSCLkDOM9AHfU2BJNLJ5N 8Wr0GV0LMxCPxXOpS+m4pKT9NCXRjxVC4b7jQkWs0y4fhHVDUQGuo07VIt+hHuY5 RZelvoNKRXGqULtpVP29dWMja3iIFbDIEBArqQ4WB6B8RaegLVKLaF4A6M6HX6O+ 7Qz/EbGVbrl3A1ztMCFfc5q+j7wzrEbUf9jNhQfOP6yWwLtcYwvYAzhrgyerSZHi WykAg8kaaSqJrQqomarSzNML7deSU0nB+qk+RPAwJ9BdL8tJYDNq0lFvsQ/kgTMH 7Y1tUX5vqzAtzwStMxzKUmIqvLsKYDmNFvTSohdtSoHbq0wZmU8= =8b91 -----END PGP SIGNATURE----- --NSyv3PxMn0vTUI/G-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html