From: Yuval Shaia <yuval.shaia@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christian Benvenuti <benve@cisco.com>,
Upinder Malhi <umalhi@cisco.com>,
Dave Goodell <dgoodell@cisco.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] IB/usnic: check for allocation failure
Date: Sun, 27 Aug 2017 11:32:09 +0300 [thread overview]
Message-ID: <20170827083208.GB5681@yuvallap> (raw)
In-Reply-To: <20170825083030.rga3kllp55xnr3jf@mwanda>
On Fri, Aug 25, 2017 at 11:43:59AM +0300, Dan Carpenter wrote:
> usnic_uiom_get_dev_list() can return ERR_PTR(-ENOMEM) so we should check
> for that.
>
> Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
> index e5f57dd49980..e8523882e33b 100644
> --- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
> +++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
> @@ -164,6 +164,8 @@ find_free_vf_and_create_qp_grp(struct usnic_ib_dev *us_ibdev,
> if (usnic_ib_share_vf) {
> /* Try to find resouces on a used vf which is in pd */
> dev_list = usnic_uiom_get_dev_list(pd->umem_pd);
> + if (IS_ERR(dev_list))
> + return ERR_CAST(dev_list);
> for (i = 0; dev_list[i]; i++) {
> dev = dev_list[i];
> vf = pci_get_drvdata(to_pci_dev(dev));
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-27 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 8:43 [PATCH] IB/usnic: check for allocation failure Dan Carpenter
2017-08-27 8:32 ` Yuval Shaia [this message]
2017-08-28 23:16 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827083208.GB5681@yuvallap \
--to=yuval.shaia@oracle.com \
--cc=benve@cisco.com \
--cc=dan.carpenter@oracle.com \
--cc=dgoodell@cisco.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=umalhi@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox