Re: [PATCH rdma-core] verbs: Encode the private ABI version number in verbs_register_driver

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

On Thu, Aug 24, 2017 at 03:56:01PM -0600, Jason Gunthorpe wrote:
> This causes the symbol table to look like:
>
>    208: 000000000000c000   142 FUNC    GLOBAL DEFAULT   13 verbs_register_driver_15@@IBVERBS_PRIVATE_15
>
> Which encodes the expected private ABI version inside the symbol name
> as well as with the symbol version.
>
> This ensures that the ABI version is checked even if the linking
> environment does not include symbol versions, for instance if an
> end user is linking a provider static library to the system dynamic
> libibverbs.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> ---
>  buildlib/config.h.in         |  1 +
>  libibverbs/driver.h          | 11 +++++++++++
>  libibverbs/libibverbs.map.in |  2 +-
>  3 files changed, 13 insertions(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]