Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 3343 bytes --]

On Mon, Aug 28, 2017 at 11:13:07AM +0200, Nicolas Morey-Chaisemartin wrote:
>
>
> Le 28/08/2017 à 11:05, Leon Romanovsky a écrit :
> > On Mon, Aug 28, 2017 at 10:17:50AM +0200, Nicolas Morey-Chaisemartin wrote:
> >>
> >> Le 28/08/2017 à 08:07, Leon Romanovsky a écrit :
> >>> On Mon, Aug 28, 2017 at 07:59:29AM +0200, Nicolas Morey-Chaisemartin wrote: >> >> >> Le 27/08/2017 à 23:47, Jason Gunthorpe a écrit : >>> On Thu, Aug 24, 2017 at 04:49:54PM +0200, Nicolas Morey-Chaisemartin wrote: >>> >>>> +install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf >>>> +sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service >>>> +chmod 0644 %{buildroot}%{_unitdir}/rdma.service >>>> +install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs >>>> +install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf >>>> +install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules >>>> +sed
> >> 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf >>>> +install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk >>>> +install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh >>> Going forward suse may not want to include this boot stuff from RH, >>> unless historical versions of suse used it or something similar. The >>> new cross-distro stuff in kernel-boot basically does the same thing. >>> >>> I'm hoping RH will discontinue their version in newer releases. >>> >>> Jason >> Do you mean that all these should not be used anymore? > > I
> >> think so, from the spotted immediately - "fixup-mtrr" - is not needed > for sure. > >> The udev rules and the few new services are now sufficient ? > > This was the intention. > > I tried dropping those files from the package and it does not seem to be fully functionnal yet.
> >> I'm running and a very old Mellanox card (mthca driver) and the rdma-load-modules@infiniband is not started. Thus ipoib and umad modules are missing.
> >>
> > Can you please resend?
> > It is not readable.
> >
> > Thanks
> >
> Sorry. The latest Thunderbird seems to screw up things regularly now :s
> The current udev system does not load the infiniband modules (ipoib, umad) for old mthca cards.

Among us, Doug is the last who has such cards.

>
> I've sent a PR that fixes this on github: https://github.com/linux-rdma/rdma-core/pull/193
> I've added a second patch for qib. On my system (and in kernel tree) the module is called ib_qib so I think the udev rule as a typo there.

Thanks

>
> Nicolas
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]