From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs Date: Tue, 5 Sep 2017 11:29:45 +0300 Message-ID: <20170905082945.GB14107@yuvallap> References: <20170904152848.3471-1-yuval.shaia@oracle.com> <20170905040826.GB1070@mtr-leonro.local> <1504585010.3360.10.camel@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1504585010.3360.10.camel-Sjgp3cTcYWE@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: "leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org" , "dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org" , "sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org" , "hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Tue, Sep 05, 2017 at 04:16:51AM +0000, Bart Van Assche wrote: > On Tue, 2017-09-05 at 07:08 +0300, Leon Romanovsky wrote: > > Why do we need to be dependent on CONFIG_BROKEN? > > Is it still valid for IB stack? > > Hello Leon, > > As far as I know "&& BROKEN" makes sense but "|| BROKEN" not. The "|| BROKEN" > part was introduced through the following patch: Can you elaborate more on (1) why BROKEN is needed and (2) why "&&" make sense and "||" not? > > > From a2b2f45be7e9138bde7fcba3b8e9257fea04d087 Mon Sep 17 00:00:00 2001 > From: Al Viro > Date: Tue, 23 Aug 2005 22:45:41 +0100 > Subject: [PATCH] [PATCH] Kconfig fix (infiniband and PCI) > > infiniband uses PCI helpers all over the place (including the core parts) and > won't build without PCI. > > Signed-off-by: Al Viro > Signed-off-by: Linus Torvalds > --- > drivers/infiniband/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig > index 79c8e2dd9c33..32cdfb30e9b4 100644 > --- a/drivers/infiniband/Kconfig > +++ b/drivers/infiniband/Kconfig > @@ -1,6 +1,7 @@ > menu "InfiniBand support" > > config INFINIBAND > + depends on PCI || BROKEN > tristate "InfiniBand support" > ---help--- > Core support for InfiniBand (IB). Make sure to also select -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html