From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-core 3/3] mlx5: Add support for sending IPoIB packets Date: Wed, 6 Sep 2017 10:53:34 -0600 Message-ID: <20170906165334.GA12002@obsidianresearch.com> References: <1504708729-15249-1-git-send-email-yishaih@mellanox.com> <1504708729-15249-4-git-send-email-yishaih@mellanox.com> <20170906160443.GC6262@obsidianresearch.com> <4151c1be-89f3-804f-8feb-5e2b0b3947bc@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4151c1be-89f3-804f-8feb-5e2b0b3947bc-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yishai Hadas Cc: Yishai Hadas , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, Sep 06, 2017 at 07:49:03PM +0300, Yishai Hadas wrote: > The commentary was focused on IPoIB as this is the main use case that we > come to solve. It is more than that, why does mlx5_post_send_underlay refer to things like MLX5_IPOIB_INLINE_MAX_HEADER_SIZE ? Those constants seem mis-named. And then there are comments like this: > /* We expect at least 4 bytes as part of first entry to hold the IPoIB header */ Which really doesn't sound general at all. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html